Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nix] allow buildIdris output to be used as a dependency in other buildIdris calls more directly #3333

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

mattpolzin
Copy link
Collaborator

Description

Following in the footsteps of a recent change to the Nixpkgs variant of buildIdris, this PR just makes it a bit easier to work with the output of the buildIdris function as an input to another Idris package. The changes are backwards compatible so they just provide more flexibility and better ergonomics going forward.

Before:

let myLib = buildIdris { ... };
in buildIdris {
  ...
  idrisLibraries = [ (myLib.library {}) ];
}

After:

let myLib = buildIdris { ... };
in buildIdris {
  ...
  idrisLibraries = [ myLib ];
}

Should this change go in the CHANGELOG?

  • If this is a fix, user-facing change, a compiler change, or a new paper
    implementation, I have updated CHANGELOG_NEXT.md (and potentially also
    CONTRIBUTORS.md).

@mattpolzin mattpolzin changed the title allow buildIdris output to be used as a dependency in other buildIdris calls more directly [nix] allow buildIdris output to be used as a dependency in other buildIdris calls more directly Jun 26, 2024
@mattpolzin mattpolzin merged commit 0ea7c59 into idris-lang:main Jun 26, 2024
22 checks passed
@mattpolzin mattpolzin deleted the nix-buildIdris-dep-leniency branch June 26, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant