fixed bugs that caused compiler to hang forever when there is %tcinline
pragma
#3257
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fuel
field in Core/Value.idr toJust 1000
. This fixed only half of the problem. total025 now terminates with fuel, bug total026 still hangs.cbs
in file Core/Termination/CallGraph.idr. This fixed the second test total026.The cause of looping in total026 is pretty complicated. Consider such an example:
The lambda function with pattern matching
\(x::xs) => ...
is actually encoded in such way(f
is a fresh variable):In CallGraph.idr, such
f
is called a case function, and they are treated specially: each timefindSCall
meets a case function, it will jump to the definition of the case function, and it won't be treated as regular function call.After tcinlining,
f
becomes a recursive definition:In such way,
findSCall
in CallGraph.idr will loop forever here, since it corresponds to a program of infinite length:The fix in CallGraph.idr introduce a new parameter
cbs
. Each timefindSCall
enters a case function, it appends the function name tocbs
. If it's already there,findSCall
then will treat it as a regular function call.