Refactor S-Exp protocols to depend on fewer Idris modules #3060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 28, 2023 15:19
Remove dependency on a lot of the compiler source-code. This means specialising some of the S-Expr parser from the general Idris2 source-code parsing code to a separate copy for the S-Expr parser. It's difficult to share source-code between the two parsers because the S-exp parser doesn't need the full token structure an Idris2 source-code requires.
buzden
reviewed
Aug 28, 2023
gallais
added
event: IDM 2023/08
gallais
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove dependency on a lot of the compiler source-code.
This means specialising some of the S-Expr parser from the general Idris2 source-code parsing code to a separate copy for the S-Expr parser.
It's difficult to share source-code between the two parsers because the S-exp parser doesn't need the full token structure an Idris2 source-code requires.
Should this change go in the CHANGELOG?
implementation, I have updated
CHANGELOG.md(and potentially alsoCONTRIBUTORS.md).