Add documentation for Not. #3045
Conversation
CHANGELOG.md
Outdated
| @@ -25,6 +25,7 @@ | |||
| * Adds documentation for unquotes `~( )`. | |||
| * Adds documentation for laziness and codata primitives: `Lazy`, `Inf`, `Delay`, | |||
| and `Force`. | |||
| * Adds documentation for `Not`. | |||
There was a problem hiding this comment.
I think, this line is added in the wrong section of the changelog. This section is for changes in REPL, and REPL has special functionality for showing documentation for syntax constructions, and this section is for such additions. You've added documentation to the source code, not to the REPL. I'm even not sure that your change should go into the changelog, since it just adds what should have been there.
There was a problem hiding this comment.
OK. I wasn't sure, but saw there were doc changes in the REPL section. I didn't see any other section for documentation. I can change the PR or withdraw it and make a new one (I think).
There was a problem hiding this comment.
It's better to change this PR
|
I undid the changes to CHANGELOG.md and CONTRIBUTORS. I can squash the commits if you want it cleaned up a bit. Maybe that would make the conversation confusing. Probably doesn't matter either way. |
Commits can usually be squashed by maintainers when merging the PR, so you can do this, but it can be done during the merge without additional steps from the PRs author. |
|
OK, thanks @buzden. If it's easy for you to squash, I'm happy to let you do that. One time I made a mess of a PR before it was finally suitable, and was asked to clean it up before it would be accepted. |
It seems I've been excessively active on commenting the PR. I don't have rights to merge PRs, I'm just a regular contributor, I just lived here long enough to know some functionality ;-) |
|
Squashed. And I assume that contrary to what I originally indicated, this should not go in the CHANGELOG. |
Description
Add documentation for Not. Based on a suggestion by Andre in discord.
Should this change go in the CHANGELOG?
Yes, I think so.
implementation, I have updated
CHANGELOG.md(and potentially alsoCONTRIBUTORS.md).