Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ fix ] Use freshly built libidris2_support in compiler #3044

Closed
wants to merge 1 commit into from

Conversation

AlgebraicWolf
Copy link
Contributor

Currently, when the compiler executable is built, libidris2_support.so from the previous compiler version is shipped with the new one. This makes it impossible to add new foreign functions to the compiler without an intermediate step adding new functions to libidris2_support.so but not using them yet. Additionally, it makes it impossible for commits that use new foreign functions to pass CI, because the compiler is first built with the last release version, which does not contain the new foreign functions in its support files.

This PR addresses the issue by replacing the libidris2_support.so file with a freshly built one.

@gallais
Copy link
Member

gallais commented Aug 14, 2023

This looks like a dangerous step towards breaking bootstrapping.

@AlgebraicWolf
Copy link
Contributor Author

I don't think I understand why that could break bootstrapping. Bootstrapping had already used the freshly built support for compiler shipped with the repository, and this PR doesn't change that.

Moreover, since freshly built support was used in bootstrapping, this fresh support was shipped with the compiler executable. Hence, this change would make the result of compiling Idris2 with previous Idris2 installation more consistent with the result of bootstrapping.

@AlgebraicWolf
Copy link
Contributor Author

Closing this as it has effectively been merged in alongside #3046

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants