Merge pull request #41 from idky137/add_conf_toml #111
ci.yml
on: push
Bitrot check
5m 16s
Clippy (MSRV)
4m 8s
Clippy (beta)
12s
Code coverage
14m 53s
Intra-doc links
6m 16s
Rustfmt
12s
Matrix: build-latest
Matrix: test
Annotations
66 errors and 4 warnings
Rustfmt
Process completed with exit code 1.
|
Clippy (beta)
The process '/home/runner/.cargo/bin/cargo' failed with exit code 1
|
Latest build on ubuntu-latest
Process completed with exit code 101.
|
Latest build on macOS-latest
The job was canceled because "ubuntu-latest" failed.
|
Latest build on macOS-latest
Process completed with exit code 101.
|
Latest build on windows-latest
The job was canceled because "ubuntu-latest" failed.
|
Latest build on windows-latest
The operation was canceled.
|
unneeded `return` statement:
zingo-rpc/src/walletrpc/service.rs#L445
error: unneeded `return` statement
--> zingo-rpc/src/walletrpc/service.rs:445:25
|
445 | / return Err(Status::invalid_argument(format!(
446 | | "Failed to parse nym address: {}",
447 | | e
448 | | )));
| |___________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
445 ~ Err(Status::invalid_argument(format!(
446 + "Failed to parse nym address: {}",
447 + e
448 ~ )))
|
|
unneeded `return` statement:
zingo-rpc/src/walletrpc/service.rs#L445
error: unneeded `return` statement
--> zingo-rpc/src/walletrpc/service.rs:445:25
|
445 | / return Err(Status::invalid_argument(format!(
446 | | "Failed to parse nym address: {}",
447 | | e
448 | | )));
| |___________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
445 ~ Err(Status::invalid_argument(format!(
446 + "Failed to parse nym address: {}",
447 + e
448 ~ )))
|
|
unneeded `return` statement:
zingo-rpc/src/walletrpc/service.rs#L257
error: unneeded `return` statement
--> zingo-rpc/src/walletrpc/service.rs:257:25
|
257 | / return Err(Status::invalid_argument(format!(
258 | | "Failed to parse nym address: {}",
259 | | e
260 | | )));
| |___________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
257 ~ Err(Status::invalid_argument(format!(
258 + "Failed to parse nym address: {}",
259 + e
260 ~ )))
|
|
unneeded `return` statement:
zingo-rpc/src/walletrpc/service.rs#L257
error: unneeded `return` statement
--> zingo-rpc/src/walletrpc/service.rs:257:25
|
257 | / return Err(Status::invalid_argument(format!(
258 | | "Failed to parse nym address: {}",
259 | | e
260 | | )));
| |___________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
257 ~ Err(Status::invalid_argument(format!(
258 + "Failed to parse nym address: {}",
259 + e
260 ~ )))
|
|
this function has too many arguments (11/7):
zingo-rpc/src/server.rs#L162
error: this function has too many arguments (11/7)
--> zingo-rpc/src/server.rs:162:5
|
162 | / pub async fn spawn(
163 | | tcp_active: bool,
164 | | tcp_ingestor_listen_addr: Option<SocketAddr>,
165 | | nym_active: bool,
... |
173 | | online: Arc<AtomicBool>,
174 | | ) -> Result<Self, ServerError> {
| |__________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
|
writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do:
zingo-rpc/src/server/worker.rs#L373
error: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
--> zingo-rpc/src/server/worker.rs:373:25
|
373 | worker_handles: &mut Vec<Option<tokio::task::JoinHandle<Result<(), WorkerError>>>>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&mut [Option<tokio::task::JoinHandle<Result<(), WorkerError>>>]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
= note: `-D clippy::ptr-arg` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::ptr_arg)]`
|
unneeded `return` statement:
zingo-rpc/src/server/worker.rs#L340
error: unneeded `return` statement
--> zingo-rpc/src/server/worker.rs:340:21
|
340 | return Ok(());
| ^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
340 ~ Ok(())
341 | }
342 ~ }
|
|
unneeded `return` statement:
zingo-rpc/src/server/worker.rs#L332
error: unneeded `return` statement
--> zingo-rpc/src/server/worker.rs:332:25
|
332 | return Ok(());
| ^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
332 ~ Ok(())
333 | }
...
341 | }
342 ~ }
|
|
unneeded `return` statement:
zingo-rpc/src/server/worker.rs#L325
error: unneeded `return` statement
--> zingo-rpc/src/server/worker.rs:325:25
|
325 | return Ok(());
| ^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `-D clippy::needless-return` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::needless_return)]`
help: remove `return`
|
325 ~ Ok(())
326 | }
...
341 | }
342 ~ }
|
|
this function has too many arguments (9/7):
zingo-rpc/src/server/worker.rs#L237
error: this function has too many arguments (9/7)
--> zingo-rpc/src/server/worker.rs:237:5
|
237 | / pub async fn spawn(
238 | | max_size: u16,
239 | | idle_size: u16,
240 | | queue: QueueReceiver<ZingoIndexerRequest>,
... |
246 | | online: Arc<AtomicBool>,
247 | | ) -> Self {
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
|
this function has too many arguments (8/7):
zingo-rpc/src/server/worker.rs#L52
error: this function has too many arguments (8/7)
--> zingo-rpc/src/server/worker.rs:52:5
|
52 | / pub async fn spawn(
53 | | worker_id: usize,
54 | | queue: QueueReceiver<ZingoIndexerRequest>,
55 | | requeue: QueueSender<ZingoIndexerRequest>,
... |
60 | | online: Arc<AtomicBool>,
61 | | ) -> Self {
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: `-D clippy::too-many-arguments` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::too_many_arguments)]`
|
this function has too many arguments (11/7):
zingo-rpc/src/server.rs#L162
error: this function has too many arguments (11/7)
--> zingo-rpc/src/server.rs:162:5
|
162 | / pub async fn spawn(
163 | | tcp_active: bool,
164 | | tcp_ingestor_listen_addr: Option<SocketAddr>,
165 | | nym_active: bool,
... |
173 | | online: Arc<AtomicBool>,
174 | | ) -> Result<Self, ServerError> {
| |__________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
|
writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do:
zingo-rpc/src/server/worker.rs#L373
error: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
--> zingo-rpc/src/server/worker.rs:373:25
|
373 | worker_handles: &mut Vec<Option<tokio::task::JoinHandle<Result<(), WorkerError>>>>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&mut [Option<tokio::task::JoinHandle<Result<(), WorkerError>>>]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
= note: `-D clippy::ptr-arg` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::ptr_arg)]`
|
unneeded `return` statement:
zingo-rpc/src/server/worker.rs#L340
error: unneeded `return` statement
--> zingo-rpc/src/server/worker.rs:340:21
|
340 | return Ok(());
| ^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
340 ~ Ok(())
341 | }
342 ~ }
|
|
unneeded `return` statement:
zingo-rpc/src/server/worker.rs#L332
error: unneeded `return` statement
--> zingo-rpc/src/server/worker.rs:332:25
|
332 | return Ok(());
| ^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
332 ~ Ok(())
333 | }
...
341 | }
342 ~ }
|
|
unneeded `return` statement:
zingo-rpc/src/server/worker.rs#L325
error: unneeded `return` statement
--> zingo-rpc/src/server/worker.rs:325:25
|
325 | return Ok(());
| ^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `-D clippy::needless-return` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::needless_return)]`
help: remove `return`
|
325 ~ Ok(())
326 | }
...
341 | }
342 ~ }
|
|
this function has too many arguments (9/7):
zingo-rpc/src/server/worker.rs#L237
error: this function has too many arguments (9/7)
--> zingo-rpc/src/server/worker.rs:237:5
|
237 | / pub async fn spawn(
238 | | max_size: u16,
239 | | idle_size: u16,
240 | | queue: QueueReceiver<ZingoIndexerRequest>,
... |
246 | | online: Arc<AtomicBool>,
247 | | ) -> Self {
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
|
this function has too many arguments (8/7):
zingo-rpc/src/server/worker.rs#L52
error: this function has too many arguments (8/7)
--> zingo-rpc/src/server/worker.rs:52:5
|
52 | / pub async fn spawn(
53 | | worker_id: usize,
54 | | queue: QueueReceiver<ZingoIndexerRequest>,
55 | | requeue: QueueSender<ZingoIndexerRequest>,
... |
60 | | online: Arc<AtomicBool>,
61 | | ) -> Self {
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: `-D clippy::too-many-arguments` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::too_many_arguments)]`
|
redundant closure:
zingo-rpc/src/primitives/block.rs#L70
error: redundant closure
--> zingo-rpc/src/primitives/block.rs:70:30
|
70 | hex::decode(hex).map(|bytes| SerializedBlock::from(bytes))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `SerializedBlock::from`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
= note: `-D clippy::redundant-closure` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::redundant_closure)]`
|
needlessly taken reference of both operands:
zingo-rpc/src/nym/utils.rs#L25
error: needlessly taken reference of both operands
--> zingo-rpc/src/nym/utils.rs:25:8
|
25 | if &body_len != &data[cursor.position() as usize..].len() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
= note: `-D clippy::op-ref` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::op_ref)]`
help: use the values directly
|
25 | if body_len != data[cursor.position() as usize..].len() {
| ~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
useless use of `format!`:
zingo-rpc/src/nym/error.rs#L45
error: useless use of `format!`
--> zingo-rpc/src/nym/error.rs:45:41
|
45 | tonic::Status::internal(format!("No AnonSenderTag received from nym mixnet"))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"No AnonSenderTag received from nym mixnet".to_string()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
|
useless use of `format!`:
zingo-rpc/src/nym/error.rs#L42
error: useless use of `format!`
--> zingo-rpc/src/nym/error.rs:42:41
|
42 | tonic::Status::internal(format!("Empty message received from nym mixnet"))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Empty message received from nym mixnet".to_string()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
= note: `-D clippy::useless-format` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::useless_format)]`
|
redundant closure:
zingo-rpc/src/primitives/block.rs#L70
error: redundant closure
--> zingo-rpc/src/primitives/block.rs:70:30
|
70 | hex::decode(hex).map(|bytes| SerializedBlock::from(bytes))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `SerializedBlock::from`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
= note: `-D clippy::redundant-closure` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::redundant_closure)]`
|
needlessly taken reference of both operands:
zingo-rpc/src/nym/utils.rs#L25
error: needlessly taken reference of both operands
--> zingo-rpc/src/nym/utils.rs:25:8
|
25 | if &body_len != &data[cursor.position() as usize..].len() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
= note: `-D clippy::op-ref` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::op_ref)]`
help: use the values directly
|
25 | if body_len != data[cursor.position() as usize..].len() {
| ~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
useless use of `format!`:
zingo-rpc/src/nym/error.rs#L45
error: useless use of `format!`
--> zingo-rpc/src/nym/error.rs:45:41
|
45 | tonic::Status::internal(format!("No AnonSenderTag received from nym mixnet"))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"No AnonSenderTag received from nym mixnet".to_string()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
|
useless use of `format!`:
zingo-rpc/src/nym/error.rs#L42
error: useless use of `format!`
--> zingo-rpc/src/nym/error.rs:42:41
|
42 | tonic::Status::internal(format!("Empty message received from nym mixnet"))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Empty message received from nym mixnet".to_string()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
= note: `-D clippy::useless-format` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::useless_format)]`
|
Clippy (MSRV)
Clippy had exited with the 101 exit code
|
unneeded `return` statement:
zingo-rpc/src/walletrpc/service.rs#L445
error: unneeded `return` statement
--> zingo-rpc/src/walletrpc/service.rs:445:25
|
445 | / return Err(Status::invalid_argument(format!(
446 | | "Failed to parse nym address: {}",
447 | | e
448 | | )));
| |___________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
445 ~ Err(Status::invalid_argument(format!(
446 + "Failed to parse nym address: {}",
447 + e
448 ~ )))
|
|
unneeded `return` statement:
zingo-rpc/src/walletrpc/service.rs#L257
error: unneeded `return` statement
--> zingo-rpc/src/walletrpc/service.rs:257:25
|
257 | / return Err(Status::invalid_argument(format!(
258 | | "Failed to parse nym address: {}",
259 | | e
260 | | )));
| |___________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
257 ~ Err(Status::invalid_argument(format!(
258 + "Failed to parse nym address: {}",
259 + e
260 ~ )))
|
|
this function has too many arguments (11/7):
zingo-rpc/src/server.rs#L162
error: this function has too many arguments (11/7)
--> zingo-rpc/src/server.rs:162:5
|
162 | / pub async fn spawn(
163 | | tcp_active: bool,
164 | | tcp_ingestor_listen_addr: Option<SocketAddr>,
165 | | nym_active: bool,
... |
173 | | online: Arc<AtomicBool>,
174 | | ) -> Result<Self, ServerError> {
| |__________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
|
writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do:
zingo-rpc/src/server/worker.rs#L373
error: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
--> zingo-rpc/src/server/worker.rs:373:25
|
373 | worker_handles: &mut Vec<Option<tokio::task::JoinHandle<Result<(), WorkerError>>>>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&mut [Option<tokio::task::JoinHandle<Result<(), WorkerError>>>]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
= note: `-D clippy::ptr-arg` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::ptr_arg)]`
|
unneeded `return` statement:
zingo-rpc/src/server/worker.rs#L340
error: unneeded `return` statement
--> zingo-rpc/src/server/worker.rs:340:21
|
340 | return Ok(());
| ^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
340 ~ Ok(())
341 | }
342 ~ }
|
|
unneeded `return` statement:
zingo-rpc/src/server/worker.rs#L332
error: unneeded `return` statement
--> zingo-rpc/src/server/worker.rs:332:25
|
332 | return Ok(());
| ^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
332 ~ Ok(())
333 | }
...
341 | }
342 ~ }
|
|
unneeded `return` statement:
zingo-rpc/src/server/worker.rs#L325
error: unneeded `return` statement
--> zingo-rpc/src/server/worker.rs:325:25
|
325 | return Ok(());
| ^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `-D clippy::needless-return` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::needless_return)]`
help: remove `return`
|
325 ~ Ok(())
326 | }
...
341 | }
342 ~ }
|
|
this function has too many arguments (9/7):
zingo-rpc/src/server/worker.rs#L237
error: this function has too many arguments (9/7)
--> zingo-rpc/src/server/worker.rs:237:5
|
237 | / pub async fn spawn(
238 | | max_size: u16,
239 | | idle_size: u16,
240 | | queue: QueueReceiver<ZingoIndexerRequest>,
... |
246 | | online: Arc<AtomicBool>,
247 | | ) -> Self {
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
|
this function has too many arguments (8/7):
zingo-rpc/src/server/worker.rs#L52
error: this function has too many arguments (8/7)
--> zingo-rpc/src/server/worker.rs:52:5
|
52 | / pub async fn spawn(
53 | | worker_id: usize,
54 | | queue: QueueReceiver<ZingoIndexerRequest>,
55 | | requeue: QueueSender<ZingoIndexerRequest>,
... |
60 | | online: Arc<AtomicBool>,
61 | | ) -> Self {
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: `-D clippy::too-many-arguments` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::too_many_arguments)]`
|
unneeded `return` statement:
zingo-rpc/src/walletrpc/service.rs#L445
error: unneeded `return` statement
--> zingo-rpc/src/walletrpc/service.rs:445:25
|
445 | / return Err(Status::invalid_argument(format!(
446 | | "Failed to parse nym address: {}",
447 | | e
448 | | )));
| |___________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
445 ~ Err(Status::invalid_argument(format!(
446 + "Failed to parse nym address: {}",
447 + e
448 ~ )))
|
|
unneeded `return` statement:
zingo-rpc/src/walletrpc/service.rs#L257
error: unneeded `return` statement
--> zingo-rpc/src/walletrpc/service.rs:257:25
|
257 | / return Err(Status::invalid_argument(format!(
258 | | "Failed to parse nym address: {}",
259 | | e
260 | | )));
| |___________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
257 ~ Err(Status::invalid_argument(format!(
258 + "Failed to parse nym address: {}",
259 + e
260 ~ )))
|
|
this function has too many arguments (11/7):
zingo-rpc/src/server.rs#L162
error: this function has too many arguments (11/7)
--> zingo-rpc/src/server.rs:162:5
|
162 | / pub async fn spawn(
163 | | tcp_active: bool,
164 | | tcp_ingestor_listen_addr: Option<SocketAddr>,
165 | | nym_active: bool,
... |
173 | | online: Arc<AtomicBool>,
174 | | ) -> Result<Self, ServerError> {
| |__________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
|
writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do:
zingo-rpc/src/server/worker.rs#L373
error: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
--> zingo-rpc/src/server/worker.rs:373:25
|
373 | worker_handles: &mut Vec<Option<tokio::task::JoinHandle<Result<(), WorkerError>>>>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&mut [Option<tokio::task::JoinHandle<Result<(), WorkerError>>>]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
= note: `-D clippy::ptr-arg` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::ptr_arg)]`
|
unneeded `return` statement:
zingo-rpc/src/server/worker.rs#L340
error: unneeded `return` statement
--> zingo-rpc/src/server/worker.rs:340:21
|
340 | return Ok(());
| ^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
340 ~ Ok(())
341 | }
342 ~ }
|
|
unneeded `return` statement:
zingo-rpc/src/server/worker.rs#L332
error: unneeded `return` statement
--> zingo-rpc/src/server/worker.rs:332:25
|
332 | return Ok(());
| ^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
332 ~ Ok(())
333 | }
...
341 | }
342 ~ }
|
|
unneeded `return` statement:
zingo-rpc/src/server/worker.rs#L325
error: unneeded `return` statement
--> zingo-rpc/src/server/worker.rs:325:25
|
325 | return Ok(());
| ^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `-D clippy::needless-return` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::needless_return)]`
help: remove `return`
|
325 ~ Ok(())
326 | }
...
341 | }
342 ~ }
|
|
this function has too many arguments (9/7):
zingo-rpc/src/server/worker.rs#L237
error: this function has too many arguments (9/7)
--> zingo-rpc/src/server/worker.rs:237:5
|
237 | / pub async fn spawn(
238 | | max_size: u16,
239 | | idle_size: u16,
240 | | queue: QueueReceiver<ZingoIndexerRequest>,
... |
246 | | online: Arc<AtomicBool>,
247 | | ) -> Self {
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
|
this function has too many arguments (8/7):
zingo-rpc/src/server/worker.rs#L52
error: this function has too many arguments (8/7)
--> zingo-rpc/src/server/worker.rs:52:5
|
52 | / pub async fn spawn(
53 | | worker_id: usize,
54 | | queue: QueueReceiver<ZingoIndexerRequest>,
55 | | requeue: QueueSender<ZingoIndexerRequest>,
... |
60 | | online: Arc<AtomicBool>,
61 | | ) -> Self {
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: `-D clippy::too-many-arguments` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::too_many_arguments)]`
|
redundant closure:
zingo-rpc/src/primitives/block.rs#L70
error: redundant closure
--> zingo-rpc/src/primitives/block.rs:70:30
|
70 | hex::decode(hex).map(|bytes| SerializedBlock::from(bytes))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `SerializedBlock::from`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
= note: `-D clippy::redundant-closure` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::redundant_closure)]`
|
needlessly taken reference of both operands:
zingo-rpc/src/nym/utils.rs#L25
error: needlessly taken reference of both operands
--> zingo-rpc/src/nym/utils.rs:25:8
|
25 | if &body_len != &data[cursor.position() as usize..].len() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
= note: `-D clippy::op-ref` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::op_ref)]`
help: use the values directly
|
25 | if body_len != data[cursor.position() as usize..].len() {
| ~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
useless use of `format!`:
zingo-rpc/src/nym/error.rs#L45
error: useless use of `format!`
--> zingo-rpc/src/nym/error.rs:45:41
|
45 | tonic::Status::internal(format!("No AnonSenderTag received from nym mixnet"))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"No AnonSenderTag received from nym mixnet".to_string()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
|
useless use of `format!`:
zingo-rpc/src/nym/error.rs#L42
error: useless use of `format!`
--> zingo-rpc/src/nym/error.rs:42:41
|
42 | tonic::Status::internal(format!("Empty message received from nym mixnet"))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Empty message received from nym mixnet".to_string()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
= note: `-D clippy::useless-format` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::useless_format)]`
|
redundant closure:
zingo-rpc/src/primitives/block.rs#L70
error: redundant closure
--> zingo-rpc/src/primitives/block.rs:70:30
|
70 | hex::decode(hex).map(|bytes| SerializedBlock::from(bytes))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `SerializedBlock::from`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
= note: `-D clippy::redundant-closure` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::redundant_closure)]`
|
needlessly taken reference of both operands:
zingo-rpc/src/nym/utils.rs#L25
error: needlessly taken reference of both operands
--> zingo-rpc/src/nym/utils.rs:25:8
|
25 | if &body_len != &data[cursor.position() as usize..].len() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
= note: `-D clippy::op-ref` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::op_ref)]`
help: use the values directly
|
25 | if body_len != data[cursor.position() as usize..].len() {
| ~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
useless use of `format!`:
zingo-rpc/src/nym/error.rs#L45
error: useless use of `format!`
--> zingo-rpc/src/nym/error.rs:45:41
|
45 | tonic::Status::internal(format!("No AnonSenderTag received from nym mixnet"))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"No AnonSenderTag received from nym mixnet".to_string()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
|
useless use of `format!`:
zingo-rpc/src/nym/error.rs#L42
error: useless use of `format!`
--> zingo-rpc/src/nym/error.rs:42:41
|
42 | tonic::Status::internal(format!("Empty message received from nym mixnet"))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Empty message received from nym mixnet".to_string()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
= note: `-D clippy::useless-format` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::useless_format)]`
|
Test on macOS-latest
Process completed with exit code 101.
|
Test on windows-latest
The job was canceled because "macOS-latest" failed.
|
Test on windows-latest
The operation was canceled.
|
Test on ubuntu-latest
The job was canceled because "macOS-latest" failed.
|
Test on ubuntu-latest
The operation was canceled.
|
Code coverage
Process completed with exit code 1.
|
Clippy (beta)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Clippy (beta)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Clippy (MSRV)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Clippy (MSRV)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|