chore: add 'options' parameter to 'groth16FullProve', and pass it through to 'wtns_calculate' #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ough to 'wtns_calculate'
|
For future-proofing, it might be a good idea to add these options to the other proving systems which call wtns_calculate (i.e. plonk_full_prove and fflonk_full_prove). We don't use those in Zupass currently, but might want to try them someday. |
|
Thanks @artwyman and @OBrezhniev - I've made the requested changes. |
OBrezhniev
approved these changes
Sep 7, 2024
|
There's missing |
OBrezhniev
merged commit 8f018e6
into
iden3:feature/wtns-memSize-option
13 checks passed
jbaylina
pushed a commit
that referenced
this pull request
Oct 18, 2024
* Use circom_runtime which supports memSize option. Passing options in wtns debug too. * chore: add 'options' parameter to 'groth16FullProve', and pass it through to 'wtns_calculate' (#519) * chore: add 'options' parameter to 'groth16FullProve', and pass it through to 'wtns_calculate' * options -> wtnsCalcOptions * also add wtnsCalcOptions argument to plonk_full_prove and fflonk_full_prove * Add missing param * Review fix * Update with fixes of circom_runtime * Use released version of circom_runtime and update deps * Build * Build * fix puppeteer (#534) * Trying to fix puppeteer * Disable the sandbox to run in GHA * Allow passing prover options (singleThread) (#533) * Allow passing prover options. First one is singleThread param for curve threadManager. * Verify proofs for both multithreaded and singlethreaded generation --------- Co-authored-by: Ivan Chub <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.