Optimize: change contract function visibility to "external" #465
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
verifyProof
function, it uses yul functions likecalldataload
&return
, which will be interpreted toCALLDATALOAD
andRETURN
opcodes, and these opcodes only make sense when the calling context is an external call.Currently, the visibility of the generated contract functions are
public
and may be used unexpected as an internal call by inherit the generated contract, like:This PR changes
public
toexternal
to avoid unexpected usage of the verifier contracts.