Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix payment list ci #67

Closed
wants to merge 24 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
ff55fdb
fix: PaymentRequestInfoData set to be public
x1m3 Dec 2, 2024
2ad871f
feat: Changed PaymentRequestInfoData from a struct to a slice type ([…
x1m3 Dec 2, 2024
04cc938
fix: Remove wrong obsolete comment
x1m3 Dec 2, 2024
14457f3
fix: PaymentProof is now a list of PayProofItem and can be constructed
x1m3 Dec 3, 2024
09de990
chore: linter complains. Avoid unneded data copy in a loop
x1m3 Dec 3, 2024
b5571f8
chore: Update golangci-lint version
x1m3 Dec 3, 2024
0ad4351
chore: debug branch name and fix go version with one in go.mod
x1m3 Dec 3, 2024
6df1f05
fix: debug branch name
x1m3 Dec 3, 2024
205def7
fix: In linter, run action checkout before action setup
x1m3 Dec 3, 2024
2e1f8ee
fix: In linter, fix cache usage by linter
x1m3 Dec 3, 2024
26ef6bd
fix: In linter, fix cache usage by linter
x1m3 Dec 3, 2024
90f6bdf
chore: Remove debug git branch
x1m3 Dec 3, 2024
c266711
chore: Update go version and libraries
x1m3 Dec 3, 2024
be2fc2c
Revert "chore: Update go version and libraries"
x1m3 Dec 3, 2024
404c2aa
Revert "chore: Remove debug git branch"
x1m3 Dec 3, 2024
89e68b9
Revert "fix: In linter, fix cache usage by linter"
x1m3 Dec 3, 2024
41639c0
Revert "fix: In linter, fix cache usage by linter"
x1m3 Dec 3, 2024
63cc913
Revert "fix: In linter, run action checkout before action setup"
x1m3 Dec 3, 2024
9540028
Revert "fix: debug branch name"
x1m3 Dec 3, 2024
b685ba3
Revert "chore: debug branch name and fix go version with one in go.mod"
x1m3 Dec 3, 2024
df0d793
Revert "chore: Update golangci-lint version"
x1m3 Dec 3, 2024
24a8646
chore: Revert test package to internal
x1m3 Dec 3, 2024
2eb2d33
feat: Do not support 1.18 version
x1m3 Dec 3, 2024
f3c98e1
feat: Minimum version to 1.21.7
x1m3 Dec 3, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: In linter, fix cache usage by linter
x1m3 committed Dec 3, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 2e1f8eea002944baad6920714df46fee3fa32dbf
3 changes: 1 addition & 2 deletions .github/workflows/ci-lint.yaml
Original file line number Diff line number Diff line change
@@ -18,9 +18,8 @@ jobs:
cache: true
- name: Print branch
run: git branch --show-current
- name: Clear golangci-lint cache
run: golangci-lint cache clean
- name: golangci-lint
uses: golangci/golangci-lint-action@v3
with:
version: v1.60.3
skip-save-cache: true

Unchanged files with check annotations Beta

if err := json.Unmarshal(data, &col); err != nil {
var single EthereumEip712Signature2021
if err := json.Unmarshal(data, &single); err != nil {
return fmt.Errorf("failed to unmarshal EthereumEip712Signature2021Col: %w", err)

Check failure on line 223 in protocol/payment.go

GitHub Actions / lint

undefined: dataType (typecheck)
}

Check failure on line 224 in protocol/payment.go

GitHub Actions / lint

undefined: eip712Signature (typecheck)
col = append(col, &single)
}
for _, item := range col {