add exists method, deprecate hasSVG and getSVG. Closes #23

src/Deprecated/GetSVG.php

@@ -0,0 +1,21 @@
+<?php
+
+namespace IdeasOnPurpose\WP\Deprecated;
+
+trait GetSVG
+{
+    /**
+     * Alias for $this->fetch()
+     * TODO: Pick a name
+     * @param mixed $key
+     * @param mixed $attributes
+     * @deprecated
+     * @return void
+     */
+    public function getSVG($key, $attributes = [])
+    {
+        return $this->fetch($key, $attributes);
+    }
+
+    abstract public function fetch($key, $attributes = []);
+}

src/Deprecated/HasSVG.php

@@ -0,0 +1,17 @@
+<?php
+
+namespace IdeasOnPurpose\WP\Deprecated;
+
+trait HasSVG
+{
+    /**
+     * Check if SVG exists
+     * @deprecated Renamed to `exists`
+     */
+    public function hasSVG($name)
+    {
+        return $this->exists($name);
+    }
+
+    abstract public function exists($name);
+}

src/SVG.php

@@ -25,6 +25,8 @@ class SVG
     use Deprecated\Directory;
     use Deprecated\DumpSymbols;
     use Deprecated\Get;
+    use Deprecated\GetSVG;
+    use Deprecated\HasSVG;
 
     public $lib = [];
 
@@ -366,10 +368,11 @@ public function normalizeKey($key)
     }
 
     /**
-     * Check if SVG exists
-     * TODO: Naming?
+     * Check whether an SVG has been registered to the library
+     * @return boolean True if the SVG exists
      */
-    public function hasSVG($name)
+
+    public function exists($name)
     {
         $key = $this->normalizeKey($name);
 
@@ -385,7 +388,7 @@ public function __get($name)
     }
 
     /**
-     * TODO: Alternate name, getSVG(). Pi
+     * TODO: Alternate name, getSVG().
      * @param string $key
      * @param array $attributes
      * @return object | WP_Error
@@ -394,11 +397,10 @@ public function fetch($key, $attributes = [])
     {
         $name = $this->normalizeKey($key);
 
-        if ($name && $this->hasSVG($name)) {
+        if ($name && $this->exists($name)) {
             $svg = $this->lib[$name];
             $svg = $this->removePrivateKeys($svg);
 
-            // $svg->name = $name;
             $atts = $this->validateAttributes($attributes);
             $svg = $this->rewrapSvg($svg, $atts);
             return $svg;
@@ -409,18 +411,6 @@ public function fetch($key, $attributes = [])
         // When to suppress errors? When to show? REST should always show errors
     }
 
-    /**
-     * Alias for $this->fetch()
-     * TODO: Pick a name
-     * @param mixed $key
-     * @param mixed $attributes
-     * @return void
-     */
-    public function getSVG($key, $attributes = [])
-    {
-        return $this->fetch($key, $attributes);
-    }
-
     /**
      * Inline SVGs directly by name
      * '.svg' extensions are stripped, so 'arrow' and 'arrow.svg' will both return the 'arrow.svg' file
@@ -455,7 +445,7 @@ public function use($key)
     {
         $name = $this->normalizeKey($key);
 
-        if ($this->hasSVG($name)) {
+        if ($this->exists($name)) {
             array_push($this->inUse, $name);
             return sprintf(
                 '<svg class="%1$s"><use xlink:href="#%1$s" href="#%1$s" /></svg>',