Skip to content

Commit

Permalink
Merge branch 'geerlingguy:master' into master
Browse files Browse the repository at this point in the history
  • Loading branch information
sorobon authored Jun 5, 2024
2 parents 6b9104a + 64b17dc commit 85e0c23
Show file tree
Hide file tree
Showing 5 changed files with 17 additions and 5 deletions.
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ jobs:
distro:
- rockylinux9
- rockylinux8
- ubuntu2404
- ubuntu2204
- ubuntu2004
- debian12
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ The main Docker repo URL, common between Debian and RHEL systems.
You can change `docker_apt_gpg_key` to a different url if you are behind a firewall or provide a trustworthy mirror.
Usually in combination with changing `docker_apt_repository` as well. `docker_apt_filename` controls the name of the source list file created in `sources.list.d`. If you are upgrading from an older (<7.0.0) version of this role, you should change this to the name of the existing file (e.g. `download_docker_com_linux_debian` on Debian) to avoid conflicting lists.

docker_yum_repo_url: "{{ docker_repo_url }}/{{ (ansible_distribution == 'Fedora') | ternary('fedora','centos') }}/docker-{{ docker_edition }}.repo"docker_edition }}.repo
docker_yum_repo_url: "{{ docker_repo_url }}/{{ (ansible_distribution == 'Fedora') | ternary('fedora','centos') }}/docker-{{ docker_edition }}.repo"
docker_yum_repo_enable_nightly: '0'
docker_yum_repo_enable_test: '0'
docker_yum_gpg_key: "{{ docker_repo_url }}/centos/gpg"
Expand Down
4 changes: 2 additions & 2 deletions defaults/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ docker_apt_release_channel: stable
# docker_apt_ansible_distribution is a workaround for Ubuntu variants which can't be identified as such by Ansible,
# and is only necessary until Docker officially supports them.
docker_apt_ansible_distribution: "{{ 'ubuntu' if ansible_distribution in ['Pop!_OS', 'Linux Mint'] else ansible_distribution }}"
docker_apt_arch: "{{ 'arm64' if ansible_architecture == 'aarch64' else 'amd64' }}"
docker_apt_repository: "deb [arch={{ docker_apt_arch }} signed-by=/etc/apt/trusted.gpg.d/docker.asc] {{ docker_repo_url }}/{{ docker_apt_ansible_distribution | lower }} {{ ansible_distribution_release }} {{ docker_apt_release_channel }}"
docker_apt_arch: "{{ 'arm64' if ansible_architecture == 'aarch64' else 'armhf' if ansible_architecture == 'armv7l' else 'amd64' }}"
docker_apt_repository: "deb [arch={{ docker_apt_arch }} signed-by=/etc/apt/keyrings/docker.asc] {{ docker_repo_url }}/{{ docker_apt_ansible_distribution | lower }} {{ ansible_distribution_release }} {{ docker_apt_release_channel }}"

Check warning on line 42 in defaults/main.yml

View workflow job for this annotation

GitHub Actions / Lint

42:201 [line-length] line too long (232 > 200 characters)

Check warning on line 42 in defaults/main.yml

View workflow job for this annotation

GitHub Actions / Lint

42:201 [line-length] line too long (232 > 200 characters)

Check warning on line 42 in defaults/main.yml

View workflow job for this annotation

GitHub Actions / Lint

42:201 [line-length] line too long (232 > 200 characters)

Check warning on line 42 in defaults/main.yml

View workflow job for this annotation

GitHub Actions / Lint

42:201 [line-length] line too long (232 > 200 characters)

Check warning on line 42 in defaults/main.yml

View workflow job for this annotation

GitHub Actions / Lint

42:201 [line-length] line too long (232 > 200 characters)

Check warning on line 42 in defaults/main.yml

View workflow job for this annotation

GitHub Actions / Lint

42:201 [line-length] line too long (232 > 200 characters)

Check warning on line 42 in defaults/main.yml

View workflow job for this annotation

GitHub Actions / Lint

42:201 [line-length] line too long (232 > 200 characters)

Check warning on line 42 in defaults/main.yml

View workflow job for this annotation

GitHub Actions / Lint

42:201 [line-length] line too long (232 > 200 characters)

Check warning on line 42 in defaults/main.yml

View workflow job for this annotation

GitHub Actions / Lint

42:201 [line-length] line too long (232 > 200 characters)
docker_apt_ignore_key_error: true
docker_apt_gpg_key: "{{ docker_repo_url }}/{{ docker_apt_ansible_distribution | lower }}/gpg"
docker_apt_gpg_key_checksum: "sha256:1500c1f56fa9e26b9b8f42452a553675796ade0807cdce11975eb98170b3a570"
Expand Down
14 changes: 12 additions & 2 deletions tasks/setup-Debian.yml
Original file line number Diff line number Diff line change
@@ -1,10 +1,14 @@
---
- name: Ensure old versions of Docker are not installed.
- # See https://docs.docker.com/engine/install/debian/#uninstall-old-versions

Check warning on line 2 in tasks/setup-Debian.yml

View workflow job for this annotation

GitHub Actions / Lint

2:3 [comments] too few spaces before comment

Check warning on line 2 in tasks/setup-Debian.yml

View workflow job for this annotation

GitHub Actions / Lint

2:3 [comments] too few spaces before comment

Check warning on line 2 in tasks/setup-Debian.yml

View workflow job for this annotation

GitHub Actions / Lint

2:3 [comments] too few spaces before comment

Check warning on line 2 in tasks/setup-Debian.yml

View workflow job for this annotation

GitHub Actions / Lint

2:3 [comments] too few spaces before comment

Check warning on line 2 in tasks/setup-Debian.yml

View workflow job for this annotation

GitHub Actions / Lint

2:3 [comments] too few spaces before comment

Check warning on line 2 in tasks/setup-Debian.yml

View workflow job for this annotation

GitHub Actions / Lint

2:3 [comments] too few spaces before comment

Check warning on line 2 in tasks/setup-Debian.yml

View workflow job for this annotation

GitHub Actions / Lint

2:3 [comments] too few spaces before comment

Check warning on line 2 in tasks/setup-Debian.yml

View workflow job for this annotation

GitHub Actions / Lint

2:3 [comments] too few spaces before comment

Check warning on line 2 in tasks/setup-Debian.yml

View workflow job for this annotation

GitHub Actions / Lint

2:3 [comments] too few spaces before comment
name: Ensure old versions of Docker are not installed.
package:
name:
- docker
- docker.io
- docker-engine
- podman-docker
- containerd
- runc
state: absent

- name: Ensure dependencies are installed.
Expand All @@ -27,10 +31,16 @@
state: present
when: ansible_distribution == 'Ubuntu' and ansible_distribution_version is version('20.04', '>=')

- name: Ensure directory exists for /etc/apt/keyrings
file:
path: /etc/apt/keyrings
state: directory
mode: '0755'

- name: Add Docker apt key.
ansible.builtin.get_url:
url: "{{ docker_apt_gpg_key }}"
dest: /etc/apt/trusted.gpg.d/docker.asc
dest: /etc/apt/keyrings/docker.asc
mode: '0644'
force: false
checksum: "{{ docker_apt_gpg_key_checksum | default(omit) }}"
Expand Down
1 change: 1 addition & 0 deletions vars/Archlinux.yml
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
---
docker_packages: "docker"
docker_compose_package: docker-compose

0 comments on commit 85e0c23

Please sign in to comment.