feat: add customizable highlighted regions to cells #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @iddan, thanks for the great library!
This change enables users to specify highlighted regions of the sheet. My goal is to enable collaborative editing a'la Google Sheets, but it could also be used for user feedback about validation, or something else entirely. I aimed to reuse and somewhat emulate the
Selectiontypes and code path. You'll also notice I had to add an initial effect to the Cell component so that highlighting would be possible before the first user interaction. Without that, there isn't bounding rect info available to set the highlighting component coordinates.Please let me know if there are any changes or additions requested.
Cheers!
react-spreadsheet-highlight-demo.mov