Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Cell feature #366

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Merge Cell feature #366

wants to merge 2 commits into from

Conversation

becory
Copy link

@becory becory commented Nov 20, 2023

Hi @iddan,

I hope you're having a great day! I've been working with this amazing component to develop an Excel viewer, but I've encountered an issue. It seems that there isn't a merge cell feature available when using this component.

I've been attempting to create a custom component, and during this process, I noticed that the dimension state is split by both rows and columns. This makes it quite challenging to implement cell merging, as the cells are not tied to specific rows and columns. Consequently, it's not possible to use the row and column index to obtain the real dimensions of the table.

image

To address this, I merged two states and used ":" in the key to specify which column should utilize this dimension. I've also created a test for the CustomMergeCell component in Storybook to ensure that the feature works as intended and achieves the desired result.

I've come across a bug in this PR that I'm currently working hard to resolve:

The dimensions seem to be misaligned with cell positions when users zoom in and out of the page.

image

I'm still in the process of testing for other potential bugs.

I'm eagerly awaiting your reply and any assistance you can provide.

Thank you very much.
Wayne

@becory
Copy link
Author

becory commented Nov 20, 2023

link issue #308

@becory becory changed the title Merge Cell feature Merge Cell feature #308 Nov 20, 2023
@becory becory changed the title Merge Cell feature #308 Merge Cell feature Nov 20, 2023
@becory
Copy link
Author

becory commented Nov 21, 2023

Hi @iddan,

I've come across another repository that uses classes to define selected and editing states in order to prevent floating problems during selection. You can find it at https://nadbm.github.io/react-datasheet/.

What are your thoughts on this solution?

@iddan
Copy link
Owner

iddan commented Dec 10, 2023

Hey @becory thank you so much for your work. I'm in a very busy period in my life. Unfortunately, I can't assist with it right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants