Add SignalRouter
to replace make_signal_handler
and connect_signal_handler
#12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ended up not using using fluent interface to connect multiple signals like I suggested in #11, because actions and widgets have separate
connect_local
methods that do not originate from the same trait. We probably bridge this with our own trait, but I'm not sure how I feel about doing so. At any rate it's not likeconnect_signal_handler
could do it, so we are not losing functionality (sugar, actually) here.Once this gets merged, I want to start closing the version. This mostly means bringing the docs and the tests (and the changelog - but this should not be that much work...) up to date, filling the missing parts when necessary. #5 and #7 will have to wait for 0.3 - 0.2 was delayed for long enough.