Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cahn-Hilliard output test #8

Merged
merged 5 commits into from
Feb 5, 2025
Merged

Add Cahn-Hilliard output test #8

merged 5 commits into from
Feb 5, 2025

Conversation

dschwen
Copy link
Member

@dschwen dschwen commented Feb 3, 2025

Refs #6

@dschwen dschwen force-pushed the cahn_hilliard_test1 branch from 954f700 to 48d15de Compare February 3, 2025 19:28
@moosebuild
Copy link

moosebuild commented Feb 3, 2025

Job Documentation, step Sync to remote on 5569391 wanted to post the following:

View the site here

This comment will be updated on new commits.

@dschwen dschwen force-pushed the cahn_hilliard_test1 branch 4 times, most recently from 10129b9 to 70ddbae Compare February 3, 2025 20:46
@moosebuild
Copy link

moosebuild commented Feb 3, 2025

Job Coverage, step Generate coverage on 5569391 wanted to post the following:

Coverage

f15a25 #8 556939
Total Total +/- New
Rate 27.72% 52.96% +25.25% 70.59%
Hits 763 1465 +702 12
Misses 1990 1301 -689 5

Diff coverage report

Full coverage report

Warnings

  • New new line coverage rate 70.59% is less than the suggested 90.0%

This comment will be updated on new commits.

@dschwen dschwen force-pushed the cahn_hilliard_test1 branch 2 times, most recently from cfba0a0 to 48b6ab6 Compare February 3, 2025 21:23
@dschwen dschwen force-pushed the cahn_hilliard_test1 branch from 48b6ab6 to 38a7e43 Compare February 3, 2025 22:03
@dschwen dschwen force-pushed the cahn_hilliard_test1 branch 3 times, most recently from 52015f8 to ce2ab3e Compare February 4, 2025 01:14
@dschwen dschwen force-pushed the cahn_hilliard_test1 branch from ce2ab3e to 1d9724c Compare February 4, 2025 05:40
@dschwen
Copy link
Member Author

dschwen commented Feb 4, 2025

These schema different look like a test harness error. What's going on here?

@dschwen
Copy link
Member Author

dschwen commented Feb 4, 2025

Ahh, this is probably a thread issue! This output system is asynchronous using a dedicated thread. I bet the time increases sometimes before the output data is written!

@dschwen dschwen marked this pull request as ready for review February 4, 2025 16:08
@dschwen dschwen force-pushed the cahn_hilliard_test1 branch 4 times, most recently from 60dd07c to 35d600b Compare February 4, 2025 23:09
@moosebuild
Copy link

Job Precheck, step Clang format on 35d600b wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/swift/docs/PRs/8/clang_format/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format f15a25196df526c288eadb521431d111405da043

@dschwen dschwen force-pushed the cahn_hilliard_test1 branch from 35d600b to 5569391 Compare February 4, 2025 23:26
@dschwen dschwen merged commit c8e5a26 into devel Feb 5, 2025
8 checks passed
@dschwen dschwen deleted the cahn_hilliard_test1 branch February 13, 2025 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants