Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test RAVEN Libraries #2143

Merged
merged 12 commits into from
Jul 7, 2023
Merged

Test RAVEN Libraries #2143

merged 12 commits into from
Jul 7, 2023

Conversation

wangcj05
Copy link
Collaborator

@wangcj05 wangcj05 commented Jul 3, 2023


Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

#1806

What are the significant changes in functionality due to this change request?

The PR will update library pandas version, and use pip to install tensorflow, netcdf4, imageio to speed up the installation process across different platform.


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added is the the analytic documentation updated/added?
  • 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

@moosebuild
Copy link

All jobs on c611d94 : canceled by @wangcj05

@moosebuild
Copy link

Job Mingw Test on 38e39c5 : invalidated by @wangcj05

FAILED: Failed tests\framework\Optimizers\SimulatedAnnealing\ExponentialSA Failed tests\framework\Optimizers\SimulatedAnnealing\CauchySA Failed tests\framework\ROM\MSR\parallel

@joshua-cogliati-inl
Copy link
Contributor

See also: idaholab/TEAL#76

Copy link
Contributor

@joshua-cogliati-inl joshua-cogliati-inl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the changes and I approve.

@moosebuild
Copy link

Job Mingw Test on 38e39c5 : invalidated by @wangcj05

time out

@moosebuild
Copy link

Job Mingw Test on 38e39c5 : invalidated by @joshua-cogliati-inl

restarted civet

@moosebuild
Copy link

Job Mingw Test on 1db2fcf : invalidated by @wangcj05

run_tests: line 144: 15271 Segmentation fault

@moosebuild
Copy link

Job Mingw Test on 1db2fcf : invalidated by @joshua-cogliati-inl

Failed tests/framework/ROM/MSR/parallel

Copy link
Contributor

@joshua-cogliati-inl joshua-cogliati-inl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and approve.

@moosebuild
Copy link

Job Mingw Test on 1db2fcf : invalidated by @wangcj05

fetch issue

@moosebuild
Copy link

Job Mingw Test on 1db2fcf : invalidated by @joshua-cogliati-inl

restarted civet

Copy link
Contributor

@joshua-cogliati-inl joshua-cogliati-inl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve.

@moosebuild
Copy link

Job Mingw Test on c186570 : invalidated by @joshua-cogliati-inl

failed with ./run_tests: line 144: 7017 Segmentation fault

@wangcj05 wangcj05 mentioned this pull request Jul 6, 2023
9 tasks
@wangcj05 wangcj05 dismissed joshua-cogliati-inl’s stale review July 6, 2023 22:37

The merge-base changed after approval.

Copy link
Contributor

@joshua-cogliati-inl joshua-cogliati-inl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve.

@joshua-cogliati-inl joshua-cogliati-inl merged commit 6a23056 into devel Jul 7, 2023
@joshua-cogliati-inl joshua-cogliati-inl deleted the wangc/lib_testing branch July 7, 2023 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants