-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added new official RAVEN plugin: FARM #1449
Conversation
Job Mingw Test on 5692c62 : invalidated by @alfoa |
@@ -13,3 +13,6 @@ | |||
[submodule "plugins/SRAW"] | |||
path = plugins/SRAW | |||
url = [email protected]:RAVEN_PLUGINS/SRAW.git | |||
[submodule "plugins/FARM"] | |||
path = plugins/FARM | |||
url = [email protected]:Argonne-National-Laboratory/FARM.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't a fix for this PR, but using ssh instead of https has been causing issues externally since we switched to it, though it does make internal to INL (e.g. testing machines) work more smoothly.
We should consider a different checklist for new submodules, probably, that helps us check documentation and such. As it is, though, this passes the checklists, since no code is directly added to RAVEN and the submodule is added like unto the others. |
Approved to merge if tests pass without further modifications. |
I agree...this is a good idea. Andrea0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR is good to me
Job Mingw Test on dae9cf5 : invalidated by @joshua-cogliati-inl failed with certificate problem. |
Job Mingw Test on dae9cf5 : invalidated by @joshua-cogliati-inl restarted civet |
Job Mingw Test on dae9cf5 : invalidated by @joshua-cogliati-inl cleaned conda |
Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
Ref. #1114
What are the significant changes in functionality due to this change request?
Addition of the new RAVEN official plugin (FARM), owned and distributed by the Argonne National Laboratory. (https://github.com/Argonne-National-Laboratory/FARM)
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.
<internalParallel>
to True.raven/tests/framework/user_guide
andraven/docs/workshop
) have been changed, the associated documentation must be reviewed and assured the text matches the example.