Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added new official RAVEN plugin: FARM #1449

Merged
merged 5 commits into from
Feb 26, 2021
Merged

added new official RAVEN plugin: FARM #1449

merged 5 commits into from
Feb 26, 2021

Conversation

alfoa
Copy link
Collaborator

@alfoa alfoa commented Feb 25, 2021


Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

Ref. #1114

What are the significant changes in functionality due to this change request?

Addition of the new RAVEN official plugin (FARM), owned and distributed by the Argonne National Laboratory. (https://github.com/Argonne-National-Laboratory/FARM)


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added is the the analytic documentation updated/added?
  • 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

@alfoa alfoa requested a review from PaulTalbot-INL February 25, 2021 22:54
@moosebuild
Copy link

Job Mingw Test on 5692c62 : invalidated by @alfoa

@@ -13,3 +13,6 @@
[submodule "plugins/SRAW"]
path = plugins/SRAW
url = [email protected]:RAVEN_PLUGINS/SRAW.git
[submodule "plugins/FARM"]
path = plugins/FARM
url = [email protected]:Argonne-National-Laboratory/FARM.git
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't a fix for this PR, but using ssh instead of https has been causing issues externally since we switched to it, though it does make internal to INL (e.g. testing machines) work more smoothly.

@PaulTalbot-INL
Copy link
Collaborator

We should consider a different checklist for new submodules, probably, that helps us check documentation and such.

As it is, though, this passes the checklists, since no code is directly added to RAVEN and the submodule is added like unto the others.

@PaulTalbot-INL
Copy link
Collaborator

Approved to merge if tests pass without further modifications.

@alfoa
Copy link
Collaborator Author

alfoa commented Feb 25, 2021

We should consider a different checklist for new submodules, probably, that helps us check documentation and such.

As it is, though, this passes the checklists, since no code is directly added to RAVEN and the submodule is added like unto the others.

I agree...this is a good idea.

Andrea0

@alfoa alfoa requested a review from mandd February 26, 2021 00:54
Copy link
Collaborator

@mandd mandd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is good to me

@mandd mandd merged commit 8c26c81 into devel Feb 26, 2021
@alfoa alfoa deleted the alfoa/FARM_new_submodule branch February 26, 2021 03:11
@moosebuild
Copy link

Job Mingw Test on dae9cf5 : invalidated by @joshua-cogliati-inl

failed with certificate problem.

@moosebuild
Copy link

Job Mingw Test on dae9cf5 : invalidated by @joshua-cogliati-inl

restarted civet

@moosebuild
Copy link

Job Mingw Test on dae9cf5 : invalidated by @joshua-cogliati-inl

cleaned conda

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants