Removing sort from RELAPparser.py

[Jimmy-INL]

---

The PR addresses issue #995, by removing the sort from RELAPparser.py.
In addition, a typo was corrected in the user manual, under runInfo.tex: the was defined as colon separated string instead of column separated.

Ref. #995.

Ref. #995

No change in functionality, and regression tests for the RELAP interface passed (at least on my machines).

---

For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

• 1. Review all computer code.
• 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
• 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
• 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
• 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
• 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
• 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
• 8. If an analytic test is changed/added is the the analytic documentation updated/added?
• 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

[wangcj05]

@Jimmy-INL The issue #995 was addressed in PR #996, you may consider to merge your PR with PR #996, please talk to @PaulTalbot-INL. In addition, there are some questions regarding the issue #995 closure checklist. Please try to resolve that issue.

[PaulTalbot-INL]

Since this involves changing exactly 8 characters in 1 line, I don't think combining the pull requests in some way makes much sense. I'll close the other pull request, as @Jimmy-INL will have the resources to properly address the concerns @wangcj05 has raised in the issue closure process.

[moosebuild]

Job Test Ubuntu 16 on 1a39983 : invalidated by @wangcj05

Could not read from remote repository

[wangcj05]

Tests failed, and I believe our devel will have similar issues:

1. framework/ROM/SKLearn/GP: we need to increase the error tolerance (small diff for Linux systems)
2. timeout for varma test
3. qsub test failed for adapted sobol
   @alfoa @PaulTalbot-INL

[Jimmy-INL]

I have loosened up the tolerance of the GP test. Let me know if there are further actions needed. Also, I remember you suggested using this PR as a guinea pig to test the machines since it is a shallow PR.

…

________________________________ From: Congjian Wang - INL <[email protected]> Sent: Tuesday, July 30, 2019 9:01:55 AM To: idaholab/raven <[email protected]> Cc: Mohammad G. Abdo <[email protected]>; Mention <[email protected]> Subject: [EXTERNAL] Re: [idaholab/raven] Removing sort from RELAPparser.py (#1024) Tests failed, and I believe our devel will have similar issues: 1. framework/ROM/SKLearn/GP: we need to increase the error tolerance (small diff for Linux systems) 2. timeout for varma test 3. qsub test failed for adapted sobol @alfoa<https://gcc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Falfoa&data=02%7C01%7Cmohammad.abdo%40inl.gov%7Cae95511d57d4453a1a2808d714fee96c%7C4cf464b7869a42368da2a98566485554%7C0%7C0%7C637000957379828165&sdata=EuMxzApYaDJ%2FI8qxaBOyoGtuEwovzsC5GgKWq0RHRD0%3D&reserved=0> @PaulTalbot-INL<https://gcc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FPaulTalbot-INL&data=02%7C01%7Cmohammad.abdo%40inl.gov%7Cae95511d57d4453a1a2808d714fee96c%7C4cf464b7869a42368da2a98566485554%7C0%7C0%7C637000957379838159&sdata=vVwiGOsZ01K%2BSs5f4jDY8%2Bas5QuVIPTy2%2Fn2dcJVRfs%3D&reserved=0> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://gcc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fidaholab%2Fraven%2Fpull%2F1024%3Femail_source%3Dnotifications%26email_token%3DAMP5ECVIEDYLC3M2RWOH7GTQCBJWHA5CNFSM4IEIYTWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3EITZI%23issuecomment-516458981&data=02%7C01%7Cmohammad.abdo%40inl.gov%7Cae95511d57d4453a1a2808d714fee96c%7C4cf464b7869a42368da2a98566485554%7C0%7C0%7C637000957379838159&sdata=j2L9NE8Auh7yRuCobgo8bFQfjseW9QAaw102JJ7Hi3k%3D&reserved=0>, or mute the thread<https://gcc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAMP5ECTRYOPRC52I23D2JX3QCBJWHANCNFSM4IEIYTWA&data=02%7C01%7Cmohammad.abdo%40inl.gov%7Cae95511d57d4453a1a2808d714fee96c%7C4cf464b7869a42368da2a98566485554%7C0%7C0%7C637000957379838159&sdata=Djmz9h1fsf3WCfVWDoNsGeeiWGusAylfy%2BpX4QS%2BVh8%3D&reserved=0>.

[moosebuild]

Job Test CentOS 7 on db38a2b : invalidated by @alfoa

[moosebuild]

Job Test CentOS 7 on db38a2b : invalidated by @alfoa

[moosebuild]

Job Test CentOS 7 on db38a2b : invalidated by @wangcj05

varma timeout

[alfoa]

Ok guys,
I changed the base of this PR from devel to a branch I just created. Unfortunately there is another problem with RELAP5 interface that has been discovered during the workshop.

I will address it there (and merge this PR in that branch)