Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if old state exists in neml2 predictor #29832

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

dschwen
Copy link
Member

@dschwen dschwen commented Feb 6, 2025

Reason

If a NEML2 model does not hav old state on the input axis the applyPredictor step in NEML2ModelExecutor will throw an exception.

Design

Use has_subaxis to check for the existence of the old state subaxis and bail early if it doesn't exist.

Impact

Enable models to run.

@dschwen dschwen force-pushed the neml2_old_state_check branch from 1e91862 to c990f43 Compare February 6, 2025 23:43
@dschwen dschwen requested review from hugary1995 and removed request for bwspenc and jiangwen84 February 6, 2025 23:43
@moosebuild
Copy link
Contributor

Job Documentation, step Docs: sync website on c990f43 wanted to post the following:

View the site here

This comment will be updated on new commits.

@hugary1995
Copy link
Contributor

I suppose this is superseded by #29794

@hugary1995
Copy link
Contributor

or no I mixed the two PRs

@moosebuild
Copy link
Contributor

Job Coverage, step Generate coverage on c990f43 wanted to post the following:

Framework coverage

Coverage did not change

Modules coverage

Solid mechanics

e5db19 #29832 c990f4
Total Total +/- New
Rate 84.99% 84.99% - 100.00%
Hits 28631 28631 - 1
Misses 5058 5058 - 0

Diff coverage report

Full coverage report

Full coverage reports

Reports

This comment will be updated on new commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants