Issue warning in --mesh-only mode if unused parameters exist in input file

[shikhar413]

Reason

Design

Impact

refs #14550, this should be merged in after #29803 is merged

[moosebuild]

Job Precheck, step Clang format on ed6f597 wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/docs/PRs/29824/clang_format/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format e5db198fdde4c8655f483c28e129107b678f240b

[moosebuild]

Job Documentation, step Docs: sync website on db92386 wanted to post the following:

View the site here

This comment will be updated on new commits.

[moosebuild]

Job Coverage, step Generate coverage on be99186 wanted to post the following:

Framework coverage

	5fce0a	#29824 be9918
	Total	Total	+/-	New
Rate	85.28%	85.28%	-0.00%	100.00%
Hits	108362	108367	+5	12
Misses	18698	18700	+2	0

Diff coverage report

Full coverage report

Modules coverage

Coverage did not change

Full coverage reports

Reports

• framework
• chemical_reactions
• combined
• contact
• electromagnetics
• external_petsc_solver
• fluid_properties
• fsi
• functional_expansion_tools
• geochemistry
• heat_transfer
• level_set
• misc
• navier_stokes
• optimization
• peridynamics
• phase_field
• porous_flow
• ray_tracing
• rdg
• reactor
• richards
• scalar_transport
• solid_mechanics
• solid_properties
• stochastic_tools
• thermal_hydraulics
• xfem

This comment will be updated on new commits.

[GiudGiud]

This is for sure an improvement. my only concern is that the "check input" is done after mesh generation still, so meshing parameters that would be critical and would make mesh generation fail when misspelled are not caught

[shikhar413]

the "check input" is done after mesh generation still, so meshing parameters that would be critical and would make mesh generation fail when misspelled are not caught

@GiudGiud one possible workaround here could be to call errorCheck() within MeshOnlyAction, so that it happens before exodus mesh outputting, what do you think?

[GiudGiud]

I think that would be a good thing to try. A bad parameter is usually a critical failure in meshing in my experience

[shikhar413]

@GiudGiud just pushed some changes that call errorCheck before mesh generation now, this should now be the desired behavior that you requested

[shikhar413]

Nice, it looks like these changes are already picking up instances in existing unit tests where unused parameters are being used

[GiudGiud]

yup a whopping 26 tests affected. this is a great fix

[shikhar413]

I'll be working towards updating the failing tests. A few things I'm noticing:

• For some reason, I am getting the following error message message tests/meshgenerators/fill_between_point_vectors_generator/bow.i:3.1: unused parameter 'pi' even though pi is being used in the input file like

pi = 3.1415926535
[Mesh]
  [fbpvg]
    type = FillBetweenPointVectorsGenerator
    positions_vector_1 = '${fparse r1*cos(th1_1/180.0*pi)} ${fparse r1*sin(th1_1/180.0*pi)} ${fparse z}
                          ${fparse r1*cos(th1_2/180.0*pi)} ${fparse r1*sin(th1_2/180.0*pi)} 0.0
                          ${fparse r1*cos(th1_3/180.0*pi)} ${fparse r1*sin(th1_3/180.0*pi)} 0.0
                          ${fparse r1*cos(th1_4/180.0*pi)} ${fparse r1*sin(th1_4/180.0*pi)} 0.0
                          ${fparse r1*cos(th1_5/180.0*pi)} ${fparse r1*sin(th1_5/180.0*pi)} 0.0'
  []
[]

• There is no parameter CartesianMeshGenerator/elem_type in meshgenerators/mesh_diagnostics_generator.amr_detection/quad_second_order, do you know what this parameter should be instead? Otherwise this test is equivalent to meshgenerators/mesh_diagnostics_generator.amr_detection/quad
• This will probably cause tests to fail in internal apps, how should we handle those?

[shikhar413]

Submitted a PR in Griffin to address controlled app test failures for Griffin:
https://github.inl.gov/ncrc/griffin/pull/2337

[shikhar413]

• For some reason, I am getting the following error message message tests/meshgenerators/fill_between_point_vectors_generator/bow.i:3.1: unused parameter 'pi' even though pi is being used in the input file like

Turns out pi is an understood constant in the MOOSE input so explicitly defining it is not needed, hence the error message

[GiudGiud]

There is no parameter CartesianMeshGenerator/elem_type in meshgenerators/mesh_diagnostics_generator.amr_detection/quad_second_order, do you know what this parameter should be instead? Otherwise this test is equivalent to

ok that's my bad unfortunately.
The only fixes that makes sense is to use this mesh generator to convert
https://mooseframework.inl.gov/source/meshgenerators/ElementOrderConversionGenerator.html
or use a GMG instead of a CMG

I ll do this now since I am looking at your PR

[GiudGiud]

it should be good now. Looks like the amr detection diagnostics were broken for high order hexes

@roystgnr can you please approve my two commits on Shikhar's PR?

[shikhar413]

Thanks, all MOOSE tests pass now, (modules parallel is unrelated). The Griffin changes were also merged (https://github.inl.gov/ncrc/griffin/pull/2337), will take some time for Griffin master to be updated. Only thing that's left is updating subchannel tests (don't have access) and addressing internal app tests (can't access).

[GiudGiud]

ok we just need to wait for the master merge there then

[GiudGiud]

nevermind there's a subchannel and some BISON failures. I can take care of BISON, subchannel should be removed

[shikhar413]

nevermind there's a subchannel and some BISON failures. I can take care of BISON, subchannel should be removed

I don't have access to subchannel, you can take care of that too right?

[GiudGiud]

yup. Subchannel is just done
On BISON now

[GiudGiud]

Bison PR https://github.inl.gov/ncrc/bison/pull/6284
Pronghorn-Subchannel PR https://github.inl.gov/ncrc/pronghorn/pull/1290

[moosebuild]

Job Controlled app tests on db92386 : invalidated by @shikhar413

[shikhar413]

Griffin controlled app tests now pass - feel free to invalidate the remaining tests when the other app PR's are through