Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AddPeriodicBCAction and BicubicInterpolation #29821

Open
wants to merge 2 commits into
base: next
Choose a base branch
from

Conversation

Silverwing747
Copy link

Reason

  • In the previous MOOSE, the AddPeriodicBCAction did not properly support array variables.
  • Additionally, the BicubicInterpolation::sample2ndDerivative function was not evaluating the mixed second derivative (ddy_dx1dx2)

Design

  • AddPeriodicBCAction Modification: Updated the setPeriodicVars method to correctly accommodate array variables. This change ensures that periodic boundary conditions can be applied consistently to all components of a array variable.
  • BicubicInterpolation Update: Modified the sample2ndDerivative function to include the computation of the mixed second derivative (ddy_dx1dx2).

@moosebuild
Copy link
Contributor

Job Precheck, step Clang format on a78912e wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/docs/PRs/29821/clang_format/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format e29a964c9f5f9bbbc2c39daa796355ca874bcdd4

@GiudGiud
Copy link
Contributor

GiudGiud commented Feb 6, 2025

Thanks for the contribution. I turned on the text and fixed the formatting / QA items.

Can you please add:

  • a unit test (in moose/unit/src/BicubicInterpolationTest.C) for the bicubic interpolation routine
  • a regression test (in moose/test/tests/bcs/periodic) for the array variable support for periodic BCs

@moosebuild
Copy link
Contributor

Job Documentation, step Docs: sync website on ddf27b9 wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

Job Coverage, step Generate coverage on ddf27b9 wanted to post the following:

Framework coverage

e29a96 #29821 ddf27b
Total Total +/- New
Rate 85.28% 85.28% -0.01% 40.00%
Hits 108338 108344 +6 10
Misses 18693 18706 +13 15

Diff coverage report

Full coverage report

Modules coverage

Coverage did not change

Full coverage reports

Reports

Warnings

  • framework new line coverage rate 40.00% is less than the suggested 90.0%

This comment will be updated on new commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants