Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take strain_free_density as initial value for density calculation #29773

Open
wants to merge 5 commits into
base: next
Choose a base branch
from

Conversation

tophmatthews
Copy link
Contributor

@tophmatthews tophmatthews commented Jan 31, 2025

Creates new MaterialPropertyName strain_free_density that will replace the now deprecated density param. This enables the use of a material property for density independent of strains (say for example, dependent on chemistry), which can be changed throughout a simulation. Added test for Density in modules/misc/test/tests as well since Density is in the misc module, but is only tested in combined (almost seems like density should be in solid_mechanics but whatevs).

ping maybe @bwspenc and @dschwen ?

Closes #29556

@moosebuild
Copy link
Contributor

moosebuild commented Jan 31, 2025

Job Documentation, step Docs: sync website on 443539c wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

moosebuild commented Feb 1, 2025

Job Coverage, step Generate coverage on 443539c wanted to post the following:

Framework coverage

Coverage did not change

Modules coverage

Misc

32662f #29773 443539
Total Total +/- New
Rate 60.92% 69.62% +8.69% 91.67%
Hits 251 291 +40 11
Misses 161 127 -34 1

Diff coverage report

Full coverage report

Full coverage reports

Reports

This comment will be updated on new commits.

@tophmatthews tophmatthews marked this pull request as ready for review February 2, 2025 20:03
@tophmatthews
Copy link
Contributor Author

Ready for you to take a look @bwspenc thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow density to change via strain-free chemistry changes
3 participants