Address Alex's review:

- prevent OOB access when initializing stateful material properties on boundary
idaholab · Feb 12, 2025 · 8b07406 · 8b07406
1 parent f93945a
commit 8b07406
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/framework/src/bcs/IntegratedBC.C b/framework/src/bcs/IntegratedBC.C
@@ -15,6 +15,7 @@
 #include "SystemBase.h"
 #include "MooseVariableFE.h"
 #include "MooseVariableScalar.h"
+#include "MaterialPropertyStorage.h"
 
 #include "libmesh/quadrature.h"
 
@@ -88,6 +89,14 @@ IntegratedBC::IntegratedBC(const InputParameters & parameters)
   }
 
   _has_diag_save_in = _diag_save_in.size() > 0;
+
+  // Stateful properties on the boundary will trigger OOB evaluations from re-initing variables out
+  // of the domain
+  if (_skip_execution_outside_variable_domain &&
+      _fe_problem.getBndMaterialPropertyStorage().hasStatefulProperties())
+    paramError("skip_execution_outside_variable_domain",
+               "Stateful boundary material properties are not supported when executing boundary "
+               "conditions outsive the variable domain");
 }
 
 void

diff --git a/framework/src/meshmodifiers/ElementSubdomainModifierBase.C b/framework/src/meshmodifiers/ElementSubdomainModifierBase.C
@@ -9,6 +9,7 @@
 
 #include "ElementSubdomainModifierBase.h"
 #include "DisplacedProblem.h"
+#include "MaterialWarehouse.h"
 
 #include "libmesh/parallel_algebra.h"
 #include "libmesh/parallel.h"
@@ -215,12 +216,14 @@ ElementSubdomainModifierBase::modify(
 
   // Initialize solution and stateful material properties
   applyIC(/*displaced=*/false);
-  initElementStatefulProps(/*displaced=*/false);
+  if (_fe_problem.getMaterialWarehouse().hasActiveObjects(0))
+    initElementStatefulProps(/*displaced=*/false);
 
   if (_displaced_mesh)
   {
     applyIC(/*displaced=*/true);
-    initElementStatefulProps(/*displaced=*/true);
+    if (_fe_problem.getMaterialWarehouse().hasActiveObjects(0))
+      initElementStatefulProps(/*displaced=*/true);
   }
 }