Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy residual eval mode #238

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from
Open

Remove legacy residual eval mode #238

wants to merge 1 commit into from
+1 −2

Conversation

lindsayad
Copy link
Member

Closes #237

@moosebuild
Copy link

Job Coverage, step Generate coverage on b5b5066 wanted to post the following:

Coverage

980dc8 #238 b5b506
Total Total +/- New
Rate 91.69% 91.71% +0.02% 100.00%
Hits 331 332 +1 1
Misses 30 30 - 0

Diff coverage report

Full coverage report

This comment will be updated on new commits.

@moosebuild
Copy link

Job Documentation, step Sync to remote on b5b5066 wanted to post the following:

View the site here

This comment will be updated on new commits.

simopier
simopier requested changes Feb 22, 2025
View reviewed changes
Copy link
Collaborator

@simopier simopier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but test debug currently gets:

test:val-2d.val-2d_csvdiff: Floating point exception signaled (floating point divide by zero)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simopier simopier simopier requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove legacy residual evaluation
3 participants
@lindsayad @moosebuild @simopier