Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy residual evaluation #237

Open
lindsayad opened this issue Feb 21, 2025 · 0 comments · May be fixed by #238
Open

Remove legacy residual evaluation #237

lindsayad opened this issue Feb 21, 2025 · 0 comments · May be fixed by #238

Comments

@lindsayad
Copy link
Member

Reason

It outputs a red legacy message. Red can look scary to users

Design

Follow the legacy message clearly written by @hugary1995

Impact

Less potentially scary messages for users and a little bit of an optimization removing an unnecessary residual evaluation every time step

@lindsayad lindsayad linked a pull request Feb 21, 2025 that will close this issue
lindsayad added a commit to lindsayad/TMAP8 that referenced this issue Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant