Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing cbcpy. #42

Merged
merged 2 commits into from
Aug 23, 2022
Merged

Removing cbcpy. #42

merged 2 commits into from
Aug 23, 2022

Conversation

joshua-cogliati-inl
Copy link
Collaborator

@joshua-cogliati-inl joshua-cogliati-inl commented Aug 23, 2022


Pull Request Description

What issue does this change request address?

Closes #41

What are the significant changes in functionality due to this change request?

Removes cbcpy from windows.


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual.
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Regression tests have to complete successfully.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test.
  • 6. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.

@joshua-cogliati-inl
Copy link
Collaborator Author

joshua-cogliati-inl commented Aug 23, 2022

Note that you can see the results of running LOGOS in python 3.8 without cbcpy in: https://civet.inl.gov/job/1151586/

So with cbcpy ( https://civet.inl.gov/job/1145673/ ):

FAILED:

Failed C:\Git\opt\build_root\raven\plugins\LOGOS/tests\Scheduling\logos_rcpsp



PASSED: 28

SKIPPED: 46

FAILED: 1

... there were failed tests for plugin LOGOS!

Without cbcpy ( https://civet.inl.gov/job/1151586/ ):

FAILED:

Failed C:\Git\opt\build_root\raven\plugins\LOGOS/tests\Scheduling\logos_rcpsp



PASSED: 28

SKIPPED: 46

FAILED: 1

... there were failed tests for plugin LOGOS!

Copy link
Collaborator

@wangcj05 wangcj05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good. Probably need to skip the logos_rcpsp test on windows since it is failing now because of no cbc solver.

@joshua-cogliati-inl
Copy link
Collaborator Author

Okay, I will add the skip.

@wangcj05
Copy link
Collaborator

checklist is good, and tests are green.

@wangcj05 wangcj05 merged commit 09b287c into devel Aug 23, 2022
@wangcj05
Copy link
Collaborator

@joshua-cogliati-inl Thanks a lot!

@joshua-cogliati-inl
Copy link
Collaborator Author

I just updated the submodule ID in idaholab/raven#1933

@joshua-cogliati-inl joshua-cogliati-inl deleted the remove_cbcpy branch August 23, 2022 16:14
@mandd mandd mentioned this pull request Mar 24, 2023
6 tasks
@wangcj05 wangcj05 mentioned this pull request Apr 19, 2023
6 tasks
@mandd mandd mentioned this pull request Oct 15, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow using LOGOS with newer versions of Python by removing cbcpy
2 participants