-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing cbcpy. #42
Removing cbcpy. #42
Conversation
Note that you can see the results of running LOGOS in python 3.8 without cbcpy in: https://civet.inl.gov/job/1151586/ So with cbcpy ( https://civet.inl.gov/job/1145673/ ):
Without cbcpy ( https://civet.inl.gov/job/1151586/ ):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks good. Probably need to skip the logos_rcpsp test on windows since it is failing now because of no cbc solver.
Okay, I will add the skip. |
checklist is good, and tests are green. |
@joshua-cogliati-inl Thanks a lot! |
I just updated the submodule ID in idaholab/raven#1933 |
Pull Request Description
What issue does this change request address?
Closes #41
What are the significant changes in functionality due to this change request?
Removes cbcpy from windows.
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.