Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing dispatches. #398

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Conversation

joshua-cogliati-inl
Copy link
Collaborator

@joshua-cogliati-inl joshua-cogliati-inl commented Jan 14, 2025


Pull Request Description

What issue does this change request address?

#74

What are the significant changes in functionality due to this change request?

Removes dispatches because it does not work with current RAVEN libraries.


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large tes.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added, the the analytic documentation must be updated/added.
  • 9. If any test used as a basis for documentation examples have been changed, the associated documentation must be reviewed and assured the text matches the example.

@dylanjm
Copy link
Collaborator

dylanjm commented Jan 15, 2025

Changes are approved to merge. We are soft deprecating dispatches compatibility for the time being. Users are free to configure a working RAVEN and DISPATCHES code. The capability will remain, we will just no longer auto download dispatches as part of our environment configuration process.

@dylanjm dylanjm merged commit 6e95ac6 into idaholab:devel Jan 15, 2025
4 checks passed
@joshua-cogliati-inl joshua-cogliati-inl deleted the remove_dispatches branch January 15, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants