Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update abbreviation handling #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

update abbreviation handling #3

wants to merge 1 commit into from

Conversation

wangcj05
Copy link
Collaborator

@wangcj05 wangcj05 commented Dec 9, 2024

… assume the abbreviation is at the end of the string


Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

This PR will update abbreviation handling when number or '-' are combined with the abbreviation and the abbreviation only presented at the end of the combination.

What are the significant changes in functionality due to this change request?

For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected.
  • 4. Automated Tests should pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.

… assume the abbreviation is at the end of the string
if word not in not_acronyms:
if word in self.abbrDict.keys():
full = self.abbrDict[word]
splitWord = re.split(r'[-\d+]', word) # split word if word contains '-' or numbers
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we perform this treatment before the abbreviation handling (in the text pre-processing steps)?

if word in self.abbrDict.keys():
full = self.abbrDict[word]
splitWord = re.split(r'[-\d+]', word) # split word if word contains '-' or numbers
checkAbbr = word if len(splitWord) == 1 else splitWord[-1]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants