Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ergoCub1.2 - Architecture correction #347

Merged
merged 2 commits into from
Apr 2, 2024
Merged

ergoCub1.2 - Architecture correction #347

merged 2 commits into from
Apr 2, 2024

Conversation

AntonioAzocar
Copy link
Member

@AntonioAzocar AntonioAzocar commented Apr 2, 2024 •
edited
Loading

Corrected architecture for ergoCub1.2 (SN002)

cc @pattacini

@AntonioAzocar AntonioAzocar requested a review from pattacini as a code owner April 2, 2024 10:17
@AntonioAzocar AntonioAzocar self-assigned this Apr 2, 2024
pattacini
pattacini requested changes Apr 2, 2024
View reviewed changes
Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AntonioAzocar

Can you please make the image weigh less than 1 MB, as done with the other architectures?

6 MB is way too much.

Thanks!

@AntonioAzocar
Copy link
Member Author

Can you please make the image weigh less than 1 MB, as done with the other architectures?

Hi @pattacini,
done!

pattacini
pattacini approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for refining the image size!

@pattacini pattacini merged commit 5c77c23 into icub-tech-iit:master Apr 2, 2024
1 check passed
@pattacini pattacini mentioned this pull request Apr 2, 2024
Merged
maggia80
maggia80 reviewed Apr 2, 2024
View reviewed changes
Copy link
Member

@maggia80 maggia80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AntonioAzocar we should change the label from eCub1.1.3 to 1.2 in the top left of the picture

@pattacini
Copy link
Member

@AntonioAzocar we should change the label from eCub1.1.3 to 1.2 in the top left of the picture

Correct!

@AntonioAzocar, you could be doing that through a dedicated PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maggia80 maggia80 maggia80 left review comments

@pattacini pattacini pattacini approved these changes

Assignees

@AntonioAzocar AntonioAzocar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AntonioAzocar @pattacini @maggia80