-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 1.2.8 (fixes, ehnacements, improved datum management) #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributions to 1.2.8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request addresses several defects and shortcomings, improves the process for handling reference frame and epoch throghout, and offers various code improvements across all applications and documentation, including:
std
andboost
, ensuring full support for compiling with C++20. This addresses C++ 17 and C++ 20 build issues due to ambiguity of data type names #230.Important notes on changes to default behaviour
Users should be aware of two major changes to the way DynAdjust handles the application of datum (reference frame and epoch):
--reference-frame
) OR the reference frame label in the header of the first input file.--epoch
).--reference-frame
) to which all stations and measurements are to be aligned. In this case (and unless provided upon executing reftran), the project reference frame and epoch set by import will be used.Acknowledgements
Special thanks to @nicgowans, @jhaasdyk-au, @jasonwheritage, @neilebrown, @alas2 for their help in identifying issues, offering suggestions, and/or testing code changes.