-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Sync with React type defs by removing deprecated pointer capture props (#215) #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+1 on this PR. Meanwhile, there are 2 workarounds
|
@wootsbot 🙏 please 🙏 |
wootsbot
approved these changes
Apr 5, 2024
@sfyr111 you just need to run |
declanlscott
added a commit
to declanlscott/fodder
that referenced
this pull request
Apr 11, 2024
remove `@ts-expect-error` on github icon since icons-pack/react-simple-icons#216 (comment) was merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue reported in #215 regarding TypeScript type errors that have surfaced due to the recent updates in React's type declarations. The root cause of this issue has been identified as the removal of the onPointerEnterCapture and onPointerLeaveCapture type definitions from React's latest type declaration file. This change can be traced back to a commit in the DefinitelyTyped repository, found here, which was part of an accepted PR DefinitelyTyped#68984.
In alignment with React's type declaration updates, I have forked the react-simple-icons project and removed references to onPointerEnterCapture and onPointerLeaveCapture from the type declarations within this project. By doing this, we ensure consistency with the upstream type definitions and resolve the type errors that users of this project were experiencing.
I have attached screenshots of the TypeScript errors that were occurring prior to these changes, demonstrating the inconsistencies with the updated React type declarations.
I greatly appreciate the effort that goes into maintaining the react-simple-icons project and I'm looking forward to contributing to its continual improvement. If there are any additional changes you'd like or feedback on this PR, I'm more than willing to collaborate. Thank you for your time and consideration, and for the opportunity to support the community that relies on this fantastic resource.
Warm regards,
Ryan