feat: sui contract #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonAndell
requested changes
Oct 21, 2024
| connection: cluster_connection::new(ctx.sender(), ctx), | ||
| orders: table::new(ctx), | ||
| finished_orders: table::new(ctx), | ||
| fee: 1, |
|
|
||
| assert!(keccak256(&order.encode()) == keccak256(&fill.get_order_bytes())); | ||
| assert!(order.get_dst_nid() == srcNid); | ||
| let take= self.funds.remove<u128,Coin<T>>(fill.get_id()); |
There was a problem hiding this comment.
Suggested change
| let take= self.funds.remove<u128,Coin<T>>(fill.get_id()); | |
| let take = self.funds.remove<u128,Coin<T>>(fill.get_id()); |
| ) { | ||
| let order_hash = keccak256(&order_bytes); | ||
| let order = swap_order::decode(&order_bytes); | ||
|
|
There was a problem hiding this comment.
Missing check
If order.srcNID != srcNetwork:
ThrowError("Mismatched order")
Comment on lines
284
to
288
| assert!(!self.finished_orders.contains<vector<u8>,bool>(order_hash),EAlreadyFinished); | ||
|
|
||
| // make sure user is filling token wanted by order | ||
| assert!(string::from_ascii(type_name::get<F>().into_string())== order.get_to_token(),EInvalidFillToken); | ||
| assert!((fill_token.value() as u128)==order.get_to_amount(),EInvalidPayoutAmount); |
There was a problem hiding this comment.
Can one add error messages to asserts?
There was a problem hiding this comment.
ya only error numbers though
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1 +/- ##
=======================================
Coverage ? 88.41%
=======================================
Files ? 7
Lines ? 535
Branches ? 0
=======================================
Hits ? 473
Misses ? 62
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Commit Message
see the guidelines for commit messages.
Changelog Entry
Checklist: