Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove retry on getChannels for initializeChannelCache #166

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

izyak
Copy link
Collaborator

@izyak izyak commented Sep 11, 2023

No description provided.

@izyak izyak self-assigned this Sep 11, 2023
@izyak izyak linked an issue Sep 11, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #166 (c4186e3) into main (f7d3413) will decrease coverage by 0.04%.
Report is 24 commits behind head on main.
The diff coverage is 10.12%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #166      +/-   ##
==========================================
- Coverage   11.59%   11.56%   -0.04%     
==========================================
  Files          83       83              
  Lines       19621    20013     +392     
==========================================
+ Hits         2275     2314      +39     
- Misses      17102    17447     +345     
- Partials      244      252       +8     
Files Changed Coverage Δ
relayer/chain.go 5.26% <0.00%> (ø)
relayer/chains/cosmos/cosmos_chain_processor.go 2.90% <0.00%> (ø)
relayer/chains/cosmos/keys.go 27.90% <0.00%> (ø)
relayer/chains/cosmos/query.go 0.00% <0.00%> (ø)
relayer/chains/icon/icon_chain_processor.go 0.00% <0.00%> (ø)
relayer/chains/icon/msg.go 66.66% <ø> (-4.77%) ⬇️
relayer/chains/icon/query.go 0.00% <0.00%> (ø)
relayer/chains/wasm/helper_debug_msg.go 0.00% <0.00%> (ø)
relayer/chains/wasm/keys.go 2.54% <0.00%> (ø)
relayer/chains/wasm/provider.go 23.28% <ø> (-0.59%) ⬇️
... and 19 more

@izyak izyak added the enhancement New feature or request label Sep 11, 2023
Copy link
Collaborator

@viveksharmapoudel viveksharmapoudel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@viveksharmapoudel viveksharmapoudel merged commit aa602d2 into main Sep 11, 2023
5 of 7 checks passed
@viveksharmapoudel viveksharmapoudel deleted the fix/no-retry-query-channels branch September 11, 2023 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove retry logic on query for getChannels
2 participants