Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: log height every hour simulateneously #126

Merged
merged 6 commits into from
Aug 9, 2023
Merged

feat: log height every hour simulateneously #126

merged 6 commits into from
Aug 9, 2023

Conversation

izyak
Copy link
Collaborator

@izyak izyak commented Aug 4, 2023

No description provided.

@izyak izyak linked an issue Aug 4, 2023 that may be closed by this pull request
Fix persistence so that snapshot is taken simultaneously for all chains. #123
Closed
@codecov
Copy link

codecov bot commented Aug 4, 2023 •
edited
Loading

Codecov Report

Merging #126 (5a6e45b) into main (f7d3413) will decrease coverage by 0.06%.
Report is 4 commits behind head on main.
The diff coverage is 0.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #126      +/-   ##
==========================================
- Coverage   11.59%   11.54%   -0.06%     
==========================================
  Files          83       83              
  Lines       19621    19691      +70     
==========================================
- Hits         2275     2273       -2     
- Misses      17102    17174      +72     
  Partials      244      244
Files Changed Coverage Δ
relayer/chains/icon/icon_chain_processor.go 0.00% <0.00%> (ø)
relayer/chains/icon/msg.go 66.66% <ø> (-4.77%) ⬇️
relayer/chains/icon/query.go 0.00% <0.00%> (ø)
relayer/chains/wasm/helper_debug_msg.go 0.00% <0.00%> (ø)
relayer/chains/wasm/query.go 0.00% <0.00%> (ø)
relayer/chains/wasm/tx.go 0.00% <0.00%> (ø)
relayer/chains/wasm/wasm_chain_processor.go 0.00% <0.00%> (ø)
relayer/channel.go 0.00% <0.00%> (ø)
relayer/connection.go 0.00% <0.00%> (ø)
relayer/processor/message_processor.go 0.00% <0.00%> (ø)
... and 5 more

@izyak izyak marked this pull request as draft August 4, 2023 06:03
@izyak izyak marked this pull request as ready for review August 7, 2023 03:54
@viveksharmapoudel
Copy link
Collaborator

please remove conflict

viveksharmapoudel
viveksharmapoudel approved these changes Aug 9, 2023
View reviewed changes
Copy link
Collaborator

@viveksharmapoudel viveksharmapoudel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@viveksharmapoudel viveksharmapoudel merged commit 2fc35ae into main Aug 9, 2023
3 of 4 checks passed
@viveksharmapoudel viveksharmapoudel deleted the fix/timely-persistence branch August 9, 2023 10:56
DeepakBomjan pushed a commit that referenced this pull request Aug 15, 2023
@izyak @viveksharmapoudel @DeepakBomjan
feat: log height every hour simulateneously (#126)
81c1701 
* feat: log height every hour simulateneously

* fix: add missing method

* fix: remove should snapshot

---------

Co-authored-by: izyak <[email protected]>
Co-authored-by: izyak <[email protected]>
Co-authored-by: viveksharmapoudel <[email protected]>
izyak added a commit to izyak/ibc-relay-test that referenced this pull request Sep 7, 2023
@izyak @viveksharmapoudel
feat: log height every hour simulateneously (icon-project#126)
fe067d8 
* feat: log height every hour simulateneously

* fix: add missing method

* fix: remove should snapshot

---------

Co-authored-by: izyak <[email protected]>
Co-authored-by: izyak <[email protected]>
Co-authored-by: viveksharmapoudel <[email protected]>
izyak added a commit that referenced this pull request Sep 8, 2023
@izyak @viveksharmapoudel
feat: log height every hour simulateneously (#126)
4512450 
* feat: log height every hour simulateneously

* fix: add missing method

* fix: remove should snapshot

---------

Co-authored-by: izyak <[email protected]>
Co-authored-by: izyak <[email protected]>
Co-authored-by: viveksharmapoudel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viveksharmapoudel viveksharmapoudel viveksharmapoudel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix persistence so that snapshot is taken simultaneously for all chains.
2 participants
@izyak @viveksharmapoudel