chore: add todos & minor fixes

icon-project · Jul 12, 2023 · ca1d8cb · ca1d8cb
1 parent 5f46ecb
commit ca1d8cb
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 3 deletions.
diff --git a/relayer/chains/archway/archway_chain_processor.go b/relayer/chains/archway/archway_chain_processor.go
@@ -74,6 +74,7 @@ const (
 	latestHeightQueryRetryDelay = 1 * time.Second
 	latestHeightQueryRetries    = 5
 
+	// TODO: review transfer to providerConfig
 	defaultMinQueryLoopDuration      = 1 * time.Second
 	defaultBalanceUpdateWaitDuration = 60 * time.Second
 	inSyncNumBlocksThreshold         = 2
@@ -305,6 +306,7 @@ func (ccp *ArchwayChainProcessor) initializeChannelState(ctx context.Context) er
 }
 
 func (ccp *ArchwayChainProcessor) queryCycle(ctx context.Context, persistence *queryCyclePersistence) error {
+	// TODO : review if redundent remove
 	status, err := ccp.nodeStatusWithRetry(ctx)
 	if err != nil {
 		// don't want to cause ArchwayChainProcessor to quit here, can retry again next cycle.
@@ -355,6 +357,8 @@ func (ccp *ArchwayChainProcessor) queryCycle(ctx context.Context, persistence *q
 
 	chainID := ccp.chainProvider.ChainId()
 
+	// TODO review: max block sync
+	//
 	for i := persistence.latestQueriedBlock + 1; i <= persistence.latestHeight; i++ {
 		var eg errgroup.Group
 		var blockRes *ctypes.ResultBlockResults
@@ -451,6 +455,8 @@ func (ccp *ArchwayChainProcessor) queryCycle(ctx context.Context, persistence *q
 	return nil
 }
 
+// TODO: review add verifier
+
 func (ccp *ArchwayChainProcessor) CollectMetrics(ctx context.Context, persistence *queryCyclePersistence) {
 	ccp.CurrentBlockHeight(ctx, persistence)
 

diff --git a/relayer/chains/icon/icon_chain_processor.go b/relayer/chains/icon/icon_chain_processor.go
@@ -641,9 +641,9 @@ func (icp *IconChainProcessor) handlePathProcessorUpdate(ctx context.Context,
 // clientState will return the most recent client state if client messages
 // have already been observed for the clientID, otherwise it will query for it.
 func (icp *IconChainProcessor) clientState(ctx context.Context, clientID string) (provider.ClientState, error) {
-	// if state, ok := icp.latestClientState[clientID]; ok {
-	// 	return state, nil
-	// }
+	if state, ok := icp.latestClientState[clientID]; ok {
+		return state, nil
+	}
 	cs, err := icp.chainProvider.QueryClientStateWithoutProof(ctx, int64(icp.latestBlock.Height), clientID)
 	if err != nil {
 		return provider.ClientState{}, err

diff --git a/relayer/chains/icon/module/app_module.go b/relayer/chains/icon/module/app_module.go
@@ -44,6 +44,10 @@ func (AppModuleBasic) RegisterInterfaces(registry codectypes.InterfaceRegistry)
 		(*MerkleProofState)(nil),
 		&icon.MerkleProofs{},
 	)
+	registry.RegisterImplementations(
+		(*exported.ClientMessage)(nil),
+		&icon.SignedHeader{},
+	)
 
 }