fix: solana concurrency issue #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sending multiple transactions concurrently to the SOLANA chain, the contract had a bug of dirty reads of the
last_saved_req_id(all proxy requests got the same last_saved_req_id) before the message was received which failed all the concurrent transactions except the first one. This PR includes the changes to be made on the relayer side to incorporate the changes made on the contract side to fix the bug. The solution was to create a proxy request account using src_nid, src_conn_sn, and the dst_conn_addr of the relayer.