Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade dependencies #870

Merged
merged 11 commits into from
Aug 7, 2024
Merged

feat: upgrade dependencies #870

merged 11 commits into from
Aug 7, 2024

Conversation

ibrizsabin
Copy link
Collaborator

@ibrizsabin ibrizsabin commented Jul 29, 2024

Description

Commit Message

type: commit message

see the guidelines for commit messages.

Changelog Entry

version: <log entry>

Checklist

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines
  • I have added version bump label on PR.

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@ibrizsabin ibrizsabin self-assigned this Jul 29, 2024
@ibrizsabin ibrizsabin added the dependencies Pull requests that update a dependency file label Jul 29, 2024
@ibrizsabin ibrizsabin changed the title Feat: upgrade dependencies feat: upgrade dependencies Jul 29, 2024
@github-actions github-actions bot added the cicd label Aug 5, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 94.16667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 76.26%. Comparing base (987dcee) to head (a1d8044).

Files Patch % Lines
...ust/common/src/ibc/core/ics23_commitment/merkle.rs 0.00% 3 Missing ⚠️
...osmwasm-vm/cw-ibc-core/src/ics02_client/handler.rs 93.33% 2 Missing ⚠️
libraries/rust/common/src/lib.rs 33.33% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #870      +/-   ##
============================================
- Coverage     76.29%   76.26%   -0.03%     
  Complexity      418      418              
============================================
  Files           155      153       -2     
  Lines         14452    14443       -9     
  Branches        292      292              
============================================
- Hits          11026    11015      -11     
- Misses         3279     3281       +2     
  Partials        147      147              
Flag Coverage Δ
java 81.53% <ø> (ø)
rust 75.40% <94.16%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
contracts/cosmwasm-vm/cw-ibc-core/src/context.rs 96.59% <ø> (ø)
contracts/cosmwasm-vm/cw-ibc-core/src/contract.rs 38.57% <100.00%> (+0.47%) ⬆️
...cosmwasm-vm/cw-ibc-core/src/ics02_client/client.rs 95.42% <100.00%> (-0.03%) ⬇️
...-vm/cw-ibc-core/src/ics03_connection/connection.rs 91.72% <100.00%> (+0.05%) ⬆️
...asm-vm/cw-ibc-core/src/ics03_connection/handler.rs 100.00% <100.00%> (ø)
...smwasm-vm/cw-ibc-core/src/ics04_channel/channel.rs 94.59% <100.00%> (+0.37%) ⬆️
...smwasm-vm/cw-ibc-core/src/ics04_channel/handler.rs 100.00% <100.00%> (ø)
.../cw-ibc-core/src/ics04_channel/handler/open_ack.rs 100.00% <ø> (ø)
...cw-ibc-core/src/ics04_channel/handler/open_init.rs 100.00% <ø> (ø)
.../cw-ibc-core/src/ics04_channel/handler/open_try.rs 100.00% <100.00%> (ø)
... and 12 more

... and 52 files with indirect coverage changes

@ibrizsabin ibrizsabin marked this pull request as ready for review August 6, 2024 07:43
@ibrizsabin ibrizsabin requested a review from gcranju August 6, 2024 07:43
gcranju
gcranju previously approved these changes Aug 6, 2024
Copy link
Collaborator

@AntonAndell AntonAndell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes looks like only formatting or changes to the built in functions. I don't know rust well enough to know that each underlying function provides no changes. We should try and run e2e tests with the changes to verify.
But otherwise changes looks good

@github-actions github-actions bot added the test Testing update for Unit test, Integration test and E2E testing label Aug 7, 2024
@github-actions github-actions bot removed the test Testing update for Unit test, Integration test and E2E testing label Aug 7, 2024
@ibrizsabin
Copy link
Collaborator Author

e2e
E2E passes intermittently so attaching the screenshot.

@ibrizsabin ibrizsabin merged commit 564cdad into main Aug 7, 2024
9 checks passed
@ibrizsabin ibrizsabin deleted the feat/upgrade-dependencies branch August 7, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cicd dependencies Pull requests that update a dependency file scripts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants