Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Require tendermint clientstate trustlevel to be >= 1/3 #828

Merged
merged 8 commits into from
Apr 26, 2024
Merged

fix: Require tendermint clientstate trustlevel to be >= 1/3 #828

merged 8 commits into from
Apr 26, 2024

Conversation

AntonAndell
Copy link
Collaborator

@AntonAndell AntonAndell commented Jan 23, 2024 •
edited
Loading

Description

Commit Message

type: commit message

see the guidelines for commit messages.

Changelog Entry

version: <log entry>

Checklist

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines
  • I have added version bump label on PR.

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@AntonAndell AntonAndell linked an issue Jan 23, 2024 that may be closed by this pull request
Verify trust level to be larger than 1/3 on tendermint client creation. #810
Closed
@AntonAndell AntonAndell added the enhancement New feature or request label Jan 23, 2024
Base automatically changed from 808-investigate-commitment-prefix-usage-in-ibc-java to 807-add-client-specific-hashing-on-ack-and-packet-data February 12, 2024 10:54
Base automatically changed from 807-add-client-specific-hashing-on-ack-and-packet-data to 805-create-ics-08-compatible-tendermint-lightclient-in-java February 12, 2024 11:17
Base automatically changed from 805-create-ics-08-compatible-tendermint-lightclient-in-java to feature/wasm-lightclient-ibc-changes March 11, 2024 08:52
@AntonAndell
feat: Apply code improvments suggested during audit (#831)
ad5c712
@AntonAndell
Merge remote-tracking branch 'origin/feature/wasm-lightclient-ibc-cha…
0c0c791 
…nges' into 810-verify-trust-level-to-be-larger-than-13-on-tendermint-client-creation
@AntonAndell
Merge branch 'feature/wasm-lightclient-ibc-changes' into 810-verify-t…
f3d0f06 
…rust-level-to-be-larger-than-13-on-tendermint-client-creation
@ibrizsabin ibrizsabin merged commit 5fcf54c into feature/wasm-lightclient-ibc-changes Apr 26, 2024
5 checks passed
@ibrizsabin ibrizsabin deleted the 810-verify-trust-level-to-be-larger-than-13-on-tendermint-client-creation branch April 26, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibrizsabin ibrizsabin ibrizsabin approved these changes

@redlarva redlarva Awaiting requested review from redlarva

@nightowl121 nightowl121 Awaiting requested review from nightowl121 nightowl121 is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Verify trust level to be larger than 1/3 on tendermint client creation.
2 participants
@AntonAndell @ibrizsabin