Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: 466 initiate btp node for archway on icon testnet #480

Closed

Conversation

DeepakBomjan
Copy link
Collaborator

Description:

Commit Message

type: commit message

see the guidelines for commit messages.

Changelog Entry

version: <log entry>

Checklist:

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@DeepakBomjan
Copy link
Collaborator Author

Hi @AntonAndell @redlarva @nightowl121 , I have added the workflow to deploy javascore contracts on Berlin testnet, I have updated the score address in gradle.properties file. The contracts which failed to deploy have been commented for now. Please have a look on failed contracts.

@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2023

Codecov Report

Merging #480 (68c476a) into main (b7dc4d1) will increase coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #480      +/-   ##
============================================
+ Coverage     67.17%   67.31%   +0.14%     
- Complexity      553      580      +27     
============================================
  Files           191      191              
  Lines         17385    17504     +119     
  Branches        350      371      +21     
============================================
+ Hits          11678    11783     +105     
  Misses         5528     5528              
- Partials        179      193      +14     
Flag Coverage Δ
java 79.69% <ø> (+0.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

@DeepakBomjan DeepakBomjan changed the title 466 initiate btp node for archway on icon testnet ci: 466 initiate btp node for archway on icon testnet Jul 10, 2023
Copy link
Collaborator

@AntonAndell AntonAndell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add a section to the readme. Like this:
https://github.com/iconloop/btp2-testnet/blob/master/README.md

berlin.contracts.tendermint=cxa2a78e9f53d4e5f1f2b0994801a0daa8cc6fcc8b
berlin.contracts.mock-app=cx3b7728befe3a6049fed4382bf2ec70c6494ec396
berlin.contracts.mock-client=cx28bea26290f009b8a4ee274de48fc84e1a83631c
# berlin.contracts.mock-dapp=cx6a52b5f7e24c2bcea7758341dcb599f18dd03ecb
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be removed, since contract wont be used

berlin.contracts.mock-client=cx28bea26290f009b8a4ee274de48fc84e1a83631c
# berlin.contracts.mock-dapp=cx6a52b5f7e24c2bcea7758341dcb599f18dd03ecb
berlin.contracts.mock-dapp-multi-protocol=cx7cb9504e8bd159fff52e6bf7f7e205b381b6191a
berlin.contracts.xcall=cx5a043c58a278cd84fea67d36d4f45b44775eeaf3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be removed, since contract wont be used

DeepakBomjan and others added 28 commits July 11, 2023 08:29
* fix: Event log for channel close init

* fix: Eventlog for channel close confirm

* chore: packet timeout after relayer update

* fix: timeout height str

* chore: handle unwrap in timeout_height

---------

Co-authored-by: izyak <[email protected]>
Co-authored-by: viveksharmapoudel <[email protected]>
Co-authored-by: ibrizsabin <[email protected]>
* fix: decouple packet

* fix: channel open init

* fix: fix channel open try

* fix: fix channel open ack

* fix: fix chan open confirm

* fix: packet ack module

* fix: unit test

* fix: fixed unit tests

* chore: build and fmt

* fix: cargo fmt

* fix: resolve comments

* fix: fix docs

* fix: remove unused import

* chore: cargo fmt

---------

Co-authored-by: sabinchitrakar <[email protected]>
…451)

* feat: Update xCall and IBC connection to lates spec and update spec

Add fee logic to connection, allow xCall to be used the same as original xCall by introducing optional parameters and admin controlled default protocols. Use per connection timeout height based on each lightclient.

* change fee claiming sn from -1 to null

* Fix review comments

* Move size compare to check the whole message rather than data only

* Use .equals to compare ports
* feat: update xcall

* fix: ensure handler

* fix: add claim fees

* fix: packet ack

* fix: send call message

* fix: fix rlp encoding

* fix: execute call

* fix: fix encoding

* fix: fix tests

* fix: handshake

* fix: xcall connection tests

* fix: remove unwanted test

* fix: add fee entry points

* feat: add types

* fix: fee add

* feat: add types

* chore: resolve comments

* fix: fix test

* fix: clippy fmt

* fix: rename project

* fix: fix event messages

* fix: configure conn msg

* fix: add reply for error

* fix: fix test

* fix: fix fees issues

* fix: remove logs

* fix: send from multi dapp

* fix: data swapped

* fix: remove ack from response

* fix: negate sn before writing ack

* fix: receive packet

* fix: rollback msg

* feat: add success response

* chore: pass build

* fix: remove set ibc config

* chore: test build

* fix: fix docs

* fix: optimize build

* fix: fix remove request on reply

* chore: resolve comments

* fix: add unclaimed ack fees

---------

Co-authored-by: sabinchitrakar <[email protected]>
* feat : e2e test framework

* feat: added a script to build a optimized jar for icon contracts

* fix: Fix xCall configuration logic

* feat: added debug logs for connection and channel creation

* fix: remove unused testnet file

* fix: clean up testsuite

* fix: clean up testsuite

---------

Co-authored-by: AntonAndell <[email protected]>
* fix: empty message root encoding

* ci: update path filters for rust codes

* fix: fix lint

---------

Co-authored-by: sabinchitrakar <[email protected]>
Co-authored-by: DeepakBomjan <[email protected]>
* fix: xcall multi add default connection

* fix: fix comment

* chore: update cosmwasm build script path

* chore: fix wasm path

* ci: fix file path

---------

Co-authored-by: sabinchitrakar <[email protected]>
Co-authored-by: DeepakBomjan <[email protected]>
* fix: next proof context

* fix: next proof context hash

* fix: next proof context

* fix: next proof context hash

* fix: fix test

* chore: pull main

* chore: build pass

* fix: cargo fmt

* chore: pull main

---------

Co-authored-by: sabinchitrakar <[email protected]>
* fix: Use complete packet when writing ack in IBC XCall Connection

* fix: remove packet conversion

* fix: remove packet rename

* fix: fix clippy cargo

* fix: remove events

* chore: check build

* ci: debug

* ci: disable rust cache

* ci: debug

* ci: debug

* ci: debug

* ci: debug

* ci: debug

* ci: debug

* fix: clippy warning

* fix: fix format

* fix: fix clippy

* fix: cargo fmt

* chore: pass build

* fix: fee comparison

---------

Co-authored-by: sabinchitrakar <[email protected]>
Co-authored-by: DeepakBomjan <[email protected]>
Co-authored-by: ibrizsabin <[email protected]>
@DeepakBomjan
Copy link
Collaborator Author

Opening new PR as the current PR carries an irrelevant changes also

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initiate BTP node for Archway on ICON testnet
7 participants