Type annotate the temporal module #604
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfisher87
added
the
review::quick
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## typecheck-apiformatting #604 +/- ##
===========================================================
+ Coverage 65.44% 65.48% +0.04%
===========================================================
Files 38 38
Lines 3128 3132 +4
Branches 601 601
===========================================================
+ Hits 2047 2051 +4
Misses 990 990
Partials 91 91 ☔ View full report in Codecov by Sentry. |
mfisher87
force-pushed
the
typecheck-temporal
branch
from
7f92261
to
e805f01
Compare
JessicaS11
reviewed
Sep 12, 2024
Comment on lines
-157
to
-158
| start_time: string, datetime.time, None | ||
| end_time: string, datetime.time, None |
There was a problem hiding this comment.
Why remove the start_time and end_time parameters? Shouldn't we just remove the type?
There was a problem hiding this comment.
Since they're part of the function signature, they will be documented automatically; we only need to mention things in the docstring that aren't already represented in the function signature. One less thing to keep in sync :)
mfisher87
force-pushed
the
typecheck-temporal
branch
from
e805f01
to
7b57037
Compare
mfisher87
force-pushed
the
typecheck-apiformatting
branch
from
ca3f553
to
3da94ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
To be merged only after merging #598 and then rebasing
Annotating this module was pretty quick! No typeguards or ignores needed.