-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add buid telemetry notes to tools packages #4067
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Slightly related to this we should really have an env variable that ca be used to disable telemetry if we don't already have it.
</PropertyGroup> | ||
``` | ||
|
||
Setting this property to `false` completely disables the computation and collection of telemetry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we also support an environment variable? If not we should.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, MSBuild supports setting build properties from environment variables.
Co-authored-by: Joe George <[email protected]>
Co-authored-by: Joe George <[email protected]>
This PR adds build telemetry section to the Protobuf and Slice tools packages.