Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add buid telemetry notes to tools packages #4067

Merged
merged 5 commits into from
Sep 16, 2024

Conversation

pepone
Copy link
Member

@pepone pepone commented Sep 16, 2024

This PR adds build telemetry section to the Protobuf and Slice tools packages.

Copy link
Member

@externl externl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Slightly related to this we should really have an env variable that ca be used to disable telemetry if we don't already have it.

</PropertyGroup>
```

Setting this property to `false` completely disables the computation and collection of telemetry.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also support an environment variable? If not we should.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, MSBuild supports setting build properties from environment variables.

tools/IceRpc.Protobuf.Tools/README.md Outdated Show resolved Hide resolved
tools/IceRpc.Slice.Tools/README.md Outdated Show resolved Hide resolved
tools/IceRpc.Protobuf.Tools/README.md Outdated Show resolved Hide resolved
tools/IceRpc.Slice.Tools/README.md Outdated Show resolved Hide resolved
@pepone pepone merged commit 998f494 into icerpc:main Sep 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants