Run trials for fixed gamma #425
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llh gamma. Change llh_f() args to accommodate for fixing gamma in minimization step, change bounds and seed only for ns and fix the gamma when minimize in run_trial method. The fixed gamma changes are NOT implemented when minimizer doesn't converge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the minimizer to accommodate for trials where gamma is fixed and only n_s is fitted.
To do so, set "fix_gamma" key to True in the
mh_dictand have the same gamma in the llh and injection energy pdfs.Changes relate to
run_trial():llh_f(ns, gamma)) for easier implementation at the minimization step (and better code readability too).