feat: Finish the change import statement feature #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClarkXia
reviewed
Dec 4, 2023
ClarkXia
reviewed
Dec 6, 2023
crates/plugin_change_package_import/src/change_package_import.rs
Outdated
Show resolved
Hide resolved
crates/plugin_change_package_import/src/change_package_import.rs
Outdated
Show resolved
Hide resolved
crates/plugin_change_package_import/src/change_package_import.rs
Outdated
Show resolved
Hide resolved
crates/plugin_change_package_import/src/change_package_import.rs
Outdated
Show resolved
Hide resolved
crates/plugin_change_package_import/src/change_package_import.rs
Outdated
Show resolved
Hide resolved
|
合并下冲突 |
libin-code
force-pushed
the
feat/plugin-update-package-import
branch
from
542a472
to
ded58f1
Compare
libin-code
force-pushed
the
feat/plugin-update-package-import
branch
from
ded58f1
to
96228be
Compare
ClarkXia
reviewed
Dec 27, 2023
crates/plugin_change_package_import/src/change_package_import.rs
Outdated
Show resolved
Hide resolved
| fn visit_mut_module_items(&mut self, stmts: &mut Vec<ModuleItem>) { | ||
| stmts.visit_mut_children_with(self); | ||
|
|
||
| *stmts = self.new_stmts.clone(); |
There was a problem hiding this comment.
new_stmts 是更新后的语句集合，保障了语句顺序，此处用新集合替换旧集合。
ClarkXia
reviewed
Jan 15, 2024
ClarkXia
approved these changes
Jan 18, 2024
delete-merged-branch
bot
deleted the
feat/plugin-update-package-import
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements this issue.