Skip to content

Commit

Permalink
fix: remove universal build
Browse files Browse the repository at this point in the history
  • Loading branch information
ClarkXia committed Nov 30, 2023
1 parent a248213 commit f6059f5
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 29 deletions.
29 changes: 1 addition & 28 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -105,38 +105,11 @@ jobs:
name: bindings-${{ matrix.settings.target }}
path: crates/node_binding/${{ env.APP_NAME }}.*.node
if-no-files-found: error
universal-macOS:
name: Build universal macOS binary
needs:
- build
runs-on: macos-latest
steps:
- uses: actions/checkout@v4
- name: Pnpm Cache # Required by some tests
uses: ./.github/actions/pnpm-cache
- name: Download macOS x64 artifact
uses: actions/download-artifact@v3
with:
name: bindings-x86_64-apple-darwin
path: crates/node_binding/
- name: Download macOS arm64 artifact
uses: actions/download-artifact@v3
with:
name: bindings-aarch64-apple-darwin
path: crates/node_binding/
- name: Combine binaries
run: cd crates/node_binding && pnpm universal
- name: Upload artifact
uses: actions/upload-artifact@v3
with:
name: bindings-universal-apple-darwin
path: crates/node_binding/${{ env.APP_NAME }}.*.node
if-no-files-found: error
publish:
name: Publish
runs-on: ubuntu-latest
needs:
- universal-macOS
- build
steps:
- uses: actions/checkout@v4
- name: Pnpm Cache # Required by some tests
Expand Down
1 change: 0 additions & 1 deletion crates/node_binding/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
"build:debug": "napi build --platform",
"build:debug:aarch64": "napi build --platform --target aarch64-apple-darwin",
"prepublishOnly": "napi prepublish -t npm",
"universal": "napi universal",
"version": "napi version"
}
}

0 comments on commit f6059f5

Please sign in to comment.