fix: sentry issues (#266)

* fix crash after onboarding if user doesn't grant notification permissions on the last step * fix "address not EOA" error handling
ice-blockchain · Feb 1, 2024 · 5675c1f · 5675c1f
1 parent d9b1988
commit 5675c1f
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/src/screens/WelcomeFlow/Onboarding/hooks/useFinishOnboarding.ts b/src/screens/WelcomeFlow/Onboarding/hooks/useFinishOnboarding.ts
@@ -34,8 +34,14 @@ export const useFinishOnboarding = () => {
     useNavigation<NativeStackNavigationProp<WelcomeStackParamList>>();
   const user = useSelector(unsafeUserSelector);
 
+  /**
+   * Do not subscribe to `canAskPermissionSelector('pushNotifications')`
+   * because otherwise the number of slides is changed
+   * when user grants / denies permissions on the "notifications" slide.
+   */
   const canAskNotificationPermission = useSelector(
     canAskPermissionSelector('pushNotifications'),
+    () => true,
   );
 
   const loading = useSelector(

diff --git a/src/store/modules/Account/sagas/updateAccount.ts b/src/store/modules/Account/sagas/updateAccount.ts
@@ -153,6 +153,10 @@ function* validateMiningBlockchainAccountAddress(
         throw new ValidationError(ValidationErrorCode.BscAddressIsNotEoa);
       }
     } catch (error) {
+      if (isValidationError(error)) {
+        throw error;
+      }
+
       const typedError = error as EoaBscAddressError;
       const networkErrorTypes: typeof typedError['name'][] = [
         'HttpRequestError',