Frontend update to match visual identity of the main website #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Visual identity to match the ibp website -- unfinished
dcolley
suggested changes
Jun 28, 2023
| @@ -30,8 +32,49 @@ | |||
| </div> | |||
| </td> | |||
| </tr> | |||
|
|
|||
| <!-- for testing only, remove when done | |||
| @@ -58,8 +61,44 @@ | |||
| <td v-if="columns.includes('updatedAt')">{{ formatDateTime(member.updatedAt) }}</td> | |||
| <td v-if="columns.includes('createdAt')">{{ formatDateTime(member.createdAt) }}</td> | |||
| </tr> | |||
|
|
|||
| <!-- for testing only, remove when done | |||
There was a problem hiding this comment.
we do not need *-copy files
| <td>{{ formatDateTime(hc.createdAt) }}</td> | ||
| </tr> | ||
|
|
||
| <!-- TESTING ONLY REMOVE AFTER |
|
|
||
| //Get JSON from Gist | ||
| var clipBorder = JSON.parse(Get('./node-map/world.json')); | ||
| var jsonFile = JSON.parse(Get('https://raw.githubusercontent.com/ibp-network/config/main/members.json')); |
There was a problem hiding this comment.
let's discuss, we already have member info in the vue store. no need to get this again
There was a problem hiding this comment.
we should refactor this into a vue component. It won't take long, and I can help if needed.
| "chart.js": "^4.3.0", | ||
| "chartjs-adapter-date-fns": "^3.0.0", | ||
| "date-fns": "^2.30.0", | ||
| "dotenv": "^16.1.4", |
There was a problem hiding this comment.
dotenv is already imported in the parent directory package.json, not needed here.
If it is needed, we only need it in the build stage, so if it's really needed it should go in devDependincies.
dcolley
reviewed
Jun 28, 2023
| </tbody> | ||
| <Loading :loading="loading"></Loading> | ||
| </table> | ||
| <table class="table is-fullwidth table-container"> |
There was a problem hiding this comment.
for some reason this table is not responsive like the others?
it's ok wide:
But between 1024px and 1324px (screen width) it's offcenter?
dcolley
added a commit
to metaspan/ibp-monitor
that referenced
this pull request
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.