Develop #18
Open
Develop #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree to have more explicit error handling. I don't like calling watch_routes twice though. |
ibotty
reviewed
Jun 15, 2017
There was a problem hiding this comment.
In my limited testing I could not reproduce. I don't understand how that could happen. The set -o pipefail should take care of that, because afaict the api call (curl) will return 403 when it cannot list routes. Do you still have your environment handy? If so, can you please oc rsh to your letsencrypt pod and do the following?
. /usr/share/letsencrypt-container/common.sh
set -o pipefail
watch_routes
echo $?
watch_routes | true
echo $?Thank you!
| log "Processing route $selfLink with domain $domainname." | ||
| get_certificate "$domainname" "$selfLink" | ||
| else | ||
| log "$(watch_routes)" |
There was a problem hiding this comment.
Can we log something more concrete? Ideas?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you forgot to add the edit role to system:serviceaccount::letsencrypt the watcher script still tries to process an empty list of routes instead of giving a hint about the error.
This solution might be only a temporary fix, but works nice in our environment. ;)