Skip to content

Commit

Permalink
fix: release Github Action (#228)
Browse files Browse the repository at this point in the history
The Action to create releases upon a tag being pushed to master has
stopped working as github.event.base_ref is always null
This commit removes the check that the tag has been pushed to the
master branch, must ensure in future that tags to trigger releases
are pushed to the correct location

Contributes to: mhub/qp-planning#7256

Signed-off-by: Dave <[email protected]>
  • Loading branch information
its-dave authored Dec 6, 2021
1 parent 94554b1 commit 0ddf89d
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/github-build-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ name: Build and create release
jobs:
build:
name: Build and upload release binary
if: github.event.base_ref == 'refs/heads/master' # only run if on master branch
runs-on: ubuntu-latest
steps:
- name: Checkout code
Expand Down Expand Up @@ -38,4 +37,4 @@ jobs:
upload_url: ${{ steps.create_release.outputs.upload_url }}
asset_path: ./target/demo-all.jar
asset_name: demo-all.jar
asset_content_type: application/java-archive
asset_content_type: application/java-archive

0 comments on commit 0ddf89d

Please sign in to comment.