Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(snowflake): ensure that timestamps are properly timezoned #10732

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Jan 27, 2025

Fixes upstream snowflake test that was not properly converting pandas Timestamps using its preferred tz_* methods

@cpcloud cpcloud added this to the 10.0 milestone Jan 27, 2025
@cpcloud cpcloud added bug Incorrect behavior inside of ibis duckdb The DuckDB backend snowflake The Snowflake backend labels Jan 27, 2025
@cpcloud cpcloud force-pushed the more-timestamp-fixes branch from 452fd3a to 73c7807 Compare January 27, 2025 12:39
@cpcloud
Copy link
Member Author

cpcloud commented Jan 27, 2025

Snowflake is passing:

cloud in 🌐 falcon in …/ibis on  more-timestamp-fixes is 📦 v9.5.0 via 🐍 v3.12.8 via ❄️  impure (ibis-3.12-env)
❯ pytest -m snowflake -n 8 --dist loadgroup -q
bringing up nodes...
............x.......x.x..x.........x...x......................x.......................x.....x..........................................................x........x.....x.......x............... [  9%]
.............................................................................x...........................x.x...............x..x.............x........x..................................x.s... [ 18%]
............................................s................s.......x........s.................x..xxx....x...........x.............x.............x................x....................x..... [ 27%]
....x.............x.....................x.........x.....x...x............x...........................xx.............x.............x............x.....x.........................x.............. [ 37%]
x.............x.x.x............x....x........x................x....x.......x......x.......x........x..x.......................x......x...........x....................x.x.........x........... [ 46%]
....x..x.x..x....x...x..............................x.......x......x........x........x...x...............x....x.......x.x....x....xxxx.xxxx....xx.xx.x...xs..x....x.....x..xx....x......x..x.. [ 55%]
.x...x.x...........x.x.xx.x..xx......x............x.xx.........x..........x.........xx......xx......x..x.......xx.........x..........x.xx.x.......x.x...x...x.x.x.......x.....x.x.x........... [ 64%]
.......................................x....xx.x.x......xx..xxx.xx....xxx.x.xxxxxx.xxx..x..x...x.xx..x.x...x....xxx.xxxx...xxx....xx.x..x..xx.xx..x.xx.xxxx.....xxxx......x................... [ 74%]
.....................................x................................x.............................x...x....................................x..................s.....x.......x..............x [ 83%]
................x.....x.....x..................................................................................x.............................................................................. [ 92%]
...s.................s..............................................s...........................................................s..................                                            [100%]
1818 passed, 10 skipped, 219 xfailed in 208.66s (0:03:28)

@cpcloud cpcloud force-pushed the more-timestamp-fixes branch from 73c7807 to 2799492 Compare January 27, 2025 13:01
@cpcloud cpcloud force-pushed the more-timestamp-fixes branch from 2799492 to bee3c21 Compare January 27, 2025 13:58
@cpcloud cpcloud merged commit 02628e8 into ibis-project:main Jan 27, 2025
61 of 62 checks passed
@cpcloud cpcloud deleted the more-timestamp-fixes branch January 27, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior inside of ibis duckdb The DuckDB backend snowflake The Snowflake backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant