Skip to content

Commit

Permalink
test: fix cloud purity tests (#10713)
Browse files Browse the repository at this point in the history
  • Loading branch information
cpcloud authored Jan 24, 2025
1 parent 5177c2c commit c7270d3
Showing 1 changed file with 8 additions and 5 deletions.
13 changes: 8 additions & 5 deletions ibis/backends/tests/test_impure.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,9 @@
]

no_udfs = [
pytest.mark.notyet("datafusion", raises=NotImplementedError),
pytest.mark.notyet(
["datafusion", "athena", "databricks"], raises=NotImplementedError
),
pytest.mark.notimpl(
[
"bigquery",
Expand Down Expand Up @@ -149,8 +151,8 @@ def test_chained_selections(alltypes, impure):
lambda table: my_random(table.float_col),
marks=[
*no_udfs,
# no "impure" argument for pyspark yet
pytest.mark.notimpl("pyspark"),
# no "impure" argument for pyspark and snowflake yet
pytest.mark.notimpl(["pyspark", "snowflake"]),
],
id="udf",
),
Expand All @@ -159,7 +161,7 @@ def test_chained_selections(alltypes, impure):


# You can work around this by doing .select().cache().select()
@pytest.mark.notyet(["clickhouse"], reason="instances are correlated")
@pytest.mark.notyet(["clickhouse", "athena"], reason="instances are correlated")
@impure_params_uncorrelated
def test_impure_uncorrelated_different_id(alltypes, impure):
# This is the opposite of test_impure_correlated.
Expand All @@ -174,7 +176,7 @@ def test_impure_uncorrelated_different_id(alltypes, impure):


# You can work around this by doing .select().cache().select()
@pytest.mark.notyet(["clickhouse"], reason="instances are correlated")
@pytest.mark.notyet(["clickhouse", "athena"], reason="instances are correlated")
@impure_params_uncorrelated
def test_impure_uncorrelated_same_id(alltypes, impure):
# Similar to test_impure_uncorrelated_different_id, but the two expressions
Expand All @@ -196,6 +198,7 @@ def test_impure_uncorrelated_same_id(alltypes, impure):
"trino",
"flink",
"bigquery",
"athena",
],
raises=AssertionError,
reason="instances are not correlated but ideally they would be",
Expand Down

0 comments on commit c7270d3

Please sign in to comment.